This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
util: show meaningful values for boxed primitives #7056
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for contributing this pull request! Here are a few pointers to make sure your submission will be considered for inclusion. Commit TooTallNate/node@5890d8d653662fca914b24eae471ef2e35abdd87 has the following error(s):
The following commiters were not found in the CLA:
You can fix all these things without opening another issue. Please see CONTRIBUTING.md for more information |
Before, `new String('foo')` would be inspected as `"{}"` which
is simply not very helpful. Now, a more meaningful
`"[String: 'foo']"` result will be returned from `util.inspect()`.
Boxed String, Boolean, and Number types are all supported.
Closes #7047
|
@Nodejs-Jenkins Fixed long commit message. I'm reasonably sure that I've already signed the CLA ;) |
|
Nice! |
|
👍 and =) |
|
LGTM |
| var raw = value; | ||
| try { | ||
| // the .valueOf() call can fail for a multitude of reasons | ||
| raw = value.valueOf(); |
There was a problem hiding this comment.
This isn't handling Date properly, but I'll patch it up.
|
Thank you, landed with minor fixes in 8874a31 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before,
new String('foo')would be inspected as"{}"which is simply notvery helpful. Now, a more meaningful
"[String: 'foo']"result will bereturned from
util.inspect().Boxed String, Boolean, and Number types are all supported.
Closes #7047