Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

build: skip vcvarsall if already set up #7087

Open
wants to merge 1 commit into from

5 participants

Brian White Nodejs Jenkins Fedor Indutny Timothy J Fontaine Trevor Norris
Brian White

Without this, running vcbuild repeatedly for some time will cause errors with msbuild saying the command line is too long (due to concatenation happening in vcvarsall).

Nodejs Jenkins

Thank you for contributing this pull request! Here are a few pointers to make sure your submission will be considered for inclusion.

The following commiters were not found in the CLA:

  • Brian White

You can fix all these things without opening another issue.

Please see CONTRIBUTING.md for more information

Timothy J Fontaine tjfontaine was assigned by indutny
Fedor Indutny
Owner

Assigning to @tjfontaine

Trevor Norris trevnorris added the build label
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Feb 9, 2014
  1. Brian White
This page is out of date. Refresh to see the latest.
Showing with 4 additions and 1 deletion.
  1. +4 −1 vcbuild.bat
5 vcbuild.bat
View
@@ -96,9 +96,11 @@ SETLOCAL
ENDLOCAL
:msbuild
-@rem Skip project generation if requested.
+@rem Skip project build if requested.
if defined nobuild goto sign
+if defined VCINSTALLDIR goto msbuild-found
+
@rem Look for Visual Studio 2013
if not defined VS120COMNTOOLS goto vc-set-2012
if not exist "%VS120COMNTOOLS%\..\..\vc\vcvarsall.bat" goto vc-set-2012
@@ -121,6 +123,7 @@ if not defined VS100COMNTOOLS goto msbuild-not-found
if not exist "%VS100COMNTOOLS%\..\..\vc\vcvarsall.bat" goto msbuild-not-found
call "%VS100COMNTOOLS%\..\..\vc\vcvarsall.bat"
if not defined VCINSTALLDIR goto msbuild-not-found
+set GYP_MSVS_VERSION=2010
goto msbuild-found
:msbuild-not-found
Something went wrong with that request. Please try again.