Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Add a trace when a empty response is send #985

Closed
wants to merge 1 commit into from

3 participants

@3rd-Eden

Add a trace so we can track down where the empty response occurred in our applications.

As seeing this

26 Apr 21:38:06 - Client 9508768464438617 connected
26 Apr 21:43:24 - Initializing client with transport "websocket"
26 Apr 21:43:24 - Client 8368203134741634 connected
This type of response MUST NOT have a body. Ignoring write() calls.
This type of response MUST NOT have a body. Ignoring write() calls.
26 Apr 21:45:08 - Initializing client with transport "websocket"

in your log doesn't really help. Having a trace back to our application or even where the error occurs does help allot when debugging such issues.

@3rd-Eden 3rd-Eden Add a trace so we can track down where the empty response occurred in…
… our applications.


As seeing this

    26 Apr 21:38:06 - Client 9508768464438617 connected
    26 Apr 21:43:24 - Initializing client with transport "websocket"
    26 Apr 21:43:24 - Client 8368203134741634 connected
    This type of response MUST NOT have a body. Ignoring write() calls.
    This type of response MUST NOT have a body. Ignoring write() calls.
    26 Apr 21:45:08 - Initializing client with transport "websocket"

in your log doesn't really help.
cdb342f
@trevnorris
Owner

This can be applied, but is it still desired functionality?

@bnoordhuis

This can be applied, but is it still desired functionality?

Seeing that the issue is over two years old an no one spoke up probably not. Closing for now, we can revisit it if requested.

@bnoordhuis bnoordhuis closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Apr 26, 2011
  1. @3rd-Eden

    Add a trace so we can track down where the empty response occurred in…

    3rd-Eden authored
    … our applications.
    
    
    As seeing this
    
        26 Apr 21:38:06 - Client 9508768464438617 connected
        26 Apr 21:43:24 - Initializing client with transport "websocket"
        26 Apr 21:43:24 - Client 8368203134741634 connected
        This type of response MUST NOT have a body. Ignoring write() calls.
        This type of response MUST NOT have a body. Ignoring write() calls.
        26 Apr 21:45:08 - Initializing client with transport "websocket"
    
    in your log doesn't really help.
This page is out of date. Refresh to see the latest.
Showing with 1 addition and 0 deletions.
  1. +1 −0  lib/http.js
View
1  lib/http.js
@@ -591,6 +591,7 @@ OutgoingMessage.prototype.write = function(chunk, encoding) {
}
if (!this._hasBody) {
+ console.trace();
console.error('This type of response MUST NOT have a body. ' +
'Ignoring write() calls.');
return true;
Something went wrong with that request. Please try again.