Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GNU uname should identify OS as illumos #195

Closed
jclulow opened this issue May 1, 2019 · 4 comments
Closed

GNU uname should identify OS as illumos #195

jclulow opened this issue May 1, 2019 · 4 comments
Assignees

Comments

@jclulow
Copy link

@jclulow jclulow commented May 1, 2019

As of bug 1956, the uname binary provided by the operating system will report illumos for uname -o instead of the traditional Solaris. Unfortunately in a pkgsrc-based zone, at least under some conditions the GNU uname appears first in PATH. A naive script may run uname -o and see the Solaris value.

We should patch the pkgsrc copy of uname to report illumos as the system version does.

See example with current trunk packages:

$ /usr/bin/uname -o
illumos
$ /opt/local/bin/uname -o
Solaris
@wiedi

This comment has been minimized.

Copy link

@wiedi wiedi commented May 2, 2019

A long time ago I played with this and had the following:

diff --git a/sysutils/coreutils/Makefile b/sysutils/coreutils/Makefile
index 82c440e..cdf8ce7 100644
--- a/sysutils/coreutils/Makefile
+++ b/sysutils/coreutils/Makefile
@@ -43,6 +43,11 @@ SUBST_FILES.libname= Makefile.in
 SUBST_SED.libname=     -e '/^src_libstdbuf_so_LDFLAGS/s,$$, -install_name ${PREFIX}/libexec/coreutils/glibstdbuf.so,'
 .endif
 
+.if ${OPSYS} == "SunOS"
+CONFIGURE_ENV+=                gl_cv_host_operating_system=illumos
+.endif
+
+
 PROGS= [ base64 basename cat chcon chgrp chmod chown chroot cksum comm \
        cp csplit cut date dd df dir dircolors dirname du hostid echo env \
        expand expr factor false fmt fold groups head id install join kill \

But that is lazy way to fix it as it would be wrong when using pkgsrc on Oracle Solaris.
Propably should just try to shell out to /usr/bin/uname -o now?

@jperkin

This comment has been minimized.

Copy link
Member

@jperkin jperkin commented May 2, 2019

Older Solaris releases don't support -o so we'd need to handle that, but yeh that seems the simplest way to do it.

@jperkin

This comment has been minimized.

Copy link
Member

@jperkin jperkin commented May 2, 2019

Note that I will need to override this for our builds anyway as they are performed on a platform prior to 1956.

netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this issue May 2, 2019
@jperkin jperkin self-assigned this May 2, 2019
@jperkin

This comment has been minimized.

Copy link
Member

@jperkin jperkin commented May 2, 2019

Fixed in trunk.

@jperkin jperkin closed this May 2, 2019
netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this issue May 19, 2019
jperkin pushed a commit that referenced this issue Jul 1, 2019
For a security fix.

Release 2.2.7 Wed June 19 2019
        Security fixes:
       #186 #262  Fix extraction of namespace prefixes from XML names;
                    XML names with multiple colons could end up in the
                    wrong namespace, and take a high amount of RAM and CPU
                    resources while processing, opening the door to
                    use for denial-of-service attacks

        Other changes:
       #195 #197  Autotools/CMake: Utilize -fvisibility=hidden to stop
                    exporting non-API symbols
            #227  Autotools: Add --without-examples and --without-tests
            #228  Autotools: Modernize configure.ac
       #245 #246  Autotools: Fix check for -fvisibility=hidden for Clang
       #247 #248  Autotools: Fix compilation for lack of docbook2x-man
       #236 #258  Autotools: Produce .tar.{gz,lz,xz} release archives
            #212  CMake: Make libdir of pkgconfig expat.pc support multilib
       #158 #263  CMake: Build man page in PROJECT_BINARY_DIR not _SOURCE_DIR
            #219  Remove fallback to bcopy, assume that memmove(3) exists
            #257  Use portable "/usr/bin/env bash" shebang (e.g. for OpenBSD)
            #243  Windows: Fix syntax of .def module definition files
                  Version info bumped from 7:8:6 to 7:9:6

        Special thanks to:
            Benjamin Peterson
            Caolán McNamara
            Hanno Böck
            KangLin
            Kishore Kunche
            Marco Maggi
            Rhodri James
            Sebastian Dröge
            userwithuid
            Yury Gribov
jperkin pushed a commit that referenced this issue Jul 20, 2019
Changes:
1.9.0
-----
### Additions
- Support for
  - `erolord` (#326)
- Add login support for `instagram` (#195)
- Add `--no-download` and `extractor.*.download` disable file downloads (#220)
- Add `-A/--abort` to specify the number of consecutive download skips before
  aborting
- Interpret `-1` as infinite retries (#300)
- Implement custom log message formats per log-level (#304)
- Implement an `mtime` post-processor that sets file modification times
  according to metadata fields (#332)
- Implement a `twitter.content` option to enable tweet text extraction
  (#333, #338)
- Enable `date-min/-max/-format` options for `tumblr` (#337)

### Changes
- Set file modification times according to their `Last-Modified` header when
  downloading (#236, #277)
    - Use `--no-mtime` or `downloader.*.mtime` to disable this behavior
- Duplicate download URLs are no longer silently ignored (controllable with
  `extractor.*.image-unique`)
- Deprecate `--abort-on-skip`

### Fixes
- Retry downloads on OpenSSL exceptions (#324)
- Ignore unavailable pins on `sexcom` instead of raising an exception (#325)
- Use Firefox's SSL/TLS ciphers to prevent Cloudflare CAPTCHAs (#342)
- Improve folder name matching on `deviantart` (#343)
- Forward cookies to `youtube-dl` to allow downloading private videos
- Miscellaneous fixes for `35photo`, `500px`, `newgrounds`, `simplyhentai`
jperkin pushed a commit that referenced this issue Sep 18, 2019
== Version 2.6 (2019-09-08)

New features::

  * core: add support of 32767 color pairs (issue #1343, issue #1345)
  * core: add option "close" in command /window (issue #853)
  * api: add infos "term_colors" and "term_color_pairs"
  * api: add function list_user_data (issue #666)
  * api: add argument "strip_items" in function string_split
  * buflist: add infolist "buflist" with list of buffer pointers (issue #1375)
  * exec: evaluate option exec.command.shell, change default value to "${env:SHELL}" (issue #1356)
  * fset: add filters "h=xxx" and "he=xxx" to filter options by description (translated or in English)
  * irc: make command char optional in server option "command" (issue #615)
  * irc: add variables "user_max_length" and "host_max_length" in server structure (issue #1387)

Bug fixes::

  * core: use fixed-width integer for computing nick and hashtable DJB2 key hashes, add values "djb2_32" and "sum_32" for option weechat.look.nick_color_hash (issue #1394)
  * core: create or update option weechat.notify.xxx when function buffer_set is called with "notify" property (issue #1390)
  * core: fix memory leak in case of error when building content of bar item for display (issue #1384)
  * core: send command line parameter to plugins only if the name starts with the plugin name followed by a colon
  * core: auto disable upgrade process (command line option "--upgrade") if the file weechat.upgrade is not found
  * core: replace newlines by spaces in argument "completion" of function hook_command (issue #538)
  * core: replace char "," by "~" in color codes to separate foreground from background (issue #1264)
  * alias: remove default aliases /AME and /AMSG (issue #1355)
  * buflist: use extra variables in option buflist.look.display_conditions (issue #1393)
  * irc: fix parsing of messages 346 (invite list), 348 (exception list), 367 (ban list) and 728 (quiet list) when there is a colon before the timestamp (issue #1396)
  * irc: fix memory leak when removing a server
  * irc: fix length of user/nick/host in split of messages (issue #1387)
  * irc: quote NICK command argument sent to the server only if there's a ":" in the nick (issue #1376, issue #1319)
  * irc: return all arguments in the PONG response to a PING (issue #1369)
  * irc: disable server reconnection when the server buffer is closed (issue #236)
  * irc: strip spaces at beginning/end of addresses in server option "addresses" (issue #195)
  * irc: fix display of enabled/disabled client capabilities received in command CAP ACK (issue #151)
  * ruby: fix conversion of big integers on 32bit architecture (issue #1395)

Tests::

  * unit: add tests on IRC ignore, message and nick functions

Build::

  * core: fix compilation with autotools on FreeBSD 12.0
  * debian: disable Javascript plugin on Debian Buster/Bullseye (issue #1374)
  * python: compile with Python 3 by default
  * python: use pkg-config to detect Python (issue #1382)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.