Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

`vmadm update` will not update nic.*.model #147

Closed
jaredmorrow opened this Issue Nov 26, 2012 · 2 comments

Comments

Projects
None yet
2 participants

The manpage for vmadm at the time of this issue being filed states that nics.*.model is able to be updated update: yes, but fails if you try to update it.

Given a .json file nic-update.json:

{
  "update_nics": [
    {
      "mac": "c2:85:7f:f2:26:db",
      "nic_tag": "admin",
      "model": "rtl8139"
    }
  ]
}

Then trying the following command (with successful output mind you):

$ vmadm update 0265a9ca-dca0-4dac-bcc0-2e8549a9a4d1 -f nic-update.json 
Successfully updated 0265a9ca-dca0-4dac-bcc0-2e8549a9a4d1

The value does not update and the following is found in the vmactions.log

[root@00-25-90-96-35-b0 /var/log]# tail -f vmactions.log 
2012-11-26T18:16:21+00:00 00-25-90-96-35-b0 update[21973]: [ID 702911 local0.info] 21.310 {
2012-11-26T18:16:21+00:00 00-25-90-96-35-b0 update[21973]: [ID 702911 local0.info] 21.310   "update_nics": [
2012-11-26T18:16:21+00:00 00-25-90-96-35-b0 update[21973]: [ID 702911 local0.info] 21.310     {
2012-11-26T18:16:21+00:00 00-25-90-96-35-b0 update[21973]: [ID 702911 local0.info] 21.310       "mac": "c2:85:7f:f2:26:db",
2012-11-26T18:16:21+00:00 00-25-90-96-35-b0 update[21973]: [ID 702911 local0.info] 21.310       "nic_tag": "admin",
2012-11-26T18:16:21+00:00 00-25-90-96-35-b0 update[21973]: [ID 702911 local0.info] 21.310       "model": "rtl8139"
2012-11-26T18:16:21+00:00 00-25-90-96-35-b0 update[21973]: [ID 702911 local0.info] 21.310     }
2012-11-26T18:16:21+00:00 00-25-90-96-35-b0 update[21973]: [ID 702911 local0.info] 21.310   ]
2012-11-26T18:16:21+00:00 00-25-90-96-35-b0 update[21973]: [ID 702911 local0.info] 21.310 }
2012-11-26T18:16:21+00:00 00-25-90-96-35-b0 update[21973]: [ID 702911 local0.warning] 21.444 Warning, invalid update property: [nics.*.model] removing from payload.

So either the manpage for vmadm should be updated, or the functionality should be fixed.

Owner

joshwilsdon commented Dec 10, 2012

Fixed per commit listed above. It now is possible to update model on a VM's nic.

Thanks Josh.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment