imgadm is broken with dsapi servers.

[ilc]

/usr/img/node_modules/assert-plus/assert.js:44
                        throw new assert.AssertionError({
                              ^
AssertionError: ensureActive (boolean) is required
    at IMGADM.sourcesGet (/usr/img/lib/imgadm.js:1100:12)
    at updateImage (/usr/img/lib/imgadm.js:1613:14)
    at async.forEachSeries.iterate (/usr/img/node_modules/async/lib/async.js:108:13)
    at Object.async.forEachSeries (/usr/img/node_modules/async/lib/async.js:124:9)
    at IMGADM.updateImages (/usr/img/lib/imgadm.js:1641:15)
    at IMGADM.listImages (/usr/img/lib/imgadm.js:1194:13)
    at doneLoading (/usr/img/lib/imgadm.js:971:25)
    at async.forEachSeries.iterate (/usr/img/node_modules/async/lib/async.js:116:25)
    at IMGADM._loadImages (/usr/img/lib/imgadm.js:964:25)
    at IMGADM._dbLoadImage (/usr/img/lib/imgadm.js:799:9)

Please fix with:

(I had to cut out some noise in the diff..)

--- imgadm.js   Sun Mar 24 16:56:09 2013
+++ /usr/img/lib/imgadm.js      Thu Mar 21 01:03:24 2013
@@ -1610,7 +1609,7 @@
             return;
         }
         var uuid = ii.manifest.uuid;
-        self.sourcesGet(uuid, function (sGetErr, imageInfo) {
+        self.sourcesGet(uuid, true, function (sGetErr, imageInfo) {
             if (sGetErr) {
                 next(sGetErr);
                 return;

[nahamu]

I ran into this same problem. There is a workaround if you are in control of the manifests being served by the dsapi server which also clarifies the problem.

This error messsage was what caught my attention:
AssertionError: ensureActive (boolean) is required

I added a property to a manifest on my dsapi server:
"state":"active"
Having done that, imgadm was then happy to import the image.

Since that "state" property is part of the imgapi, but not part of the dsapi, I would describe the problem thus:
imgadm is checking the "state" property on all manifests when arguably it should only check that property when the manifest comes from an imgapi server, and should definitely not check that property when the manifest comes from a dsapi server.

I'm mentioning @trentm to get his attention since I suspect this issue will end up in his lap.
-Nahum

[trentm]

Sorry that I didn't catch this. Looking now.

[trentm]

Commit 0c7d7de is also relevant here. Without that commit, imgadm was refusing to import images from a DSAPI source. I broke this about two weeks ago with a64b572