Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filesystems description should match nics in vmadm(1M) #253

Closed
szaydel opened this issue Aug 21, 2013 · 2 comments
Closed

filesystems description should match nics in vmadm(1M) #253

szaydel opened this issue Aug 21, 2013 · 2 comments

Comments

@szaydel
Copy link
Contributor

@szaydel szaydel commented Aug 21, 2013

After reviewing the manpage for vmadm I think that section that describes filesystems does not exactly match with sections that describe disks or nics.

It looks like the heading is filesystems: plural and all sub-sections, if they were to match the formatting should be headed with:

filesystems.*.property.

For example, this should be:

     filesystems:

         This property can be used to mount additional filesystems into an OS
         VM. It is primarily intended for SDC special VMs.  The value is an
         array of objects. Those objects can have the following properties:
         source, target, raw (optional), type and options.  These are described
         below:

     filesystems.*.type:

instead it is currently:

     filesystems:

         This property can be used to mount additional filesystems into an OS
         VM. It is primarily intended for SDC special VMs.  The value is an
         array of objects. Those objects can have the following properties:
         source, target, raw (optional), type and options.  These are described
         below:

     filesystem.type:

         For OS VMs this specifies the type of the filesystem being mounted in.
         Example: lofs

         type: string (fs type)
         vmtype: OS
         listable: no
         create: yes
         update: no
@szaydel

This comment has been minimized.

Copy link
Contributor Author

@szaydel szaydel commented Aug 22, 2013

Pull request referenced in issue 254 addresses this inconsistent style.

@rmustacc

This comment has been minimized.

Copy link
Contributor

@rmustacc rmustacc commented Aug 22, 2013

Resolved in f9716b5.

@rmustacc rmustacc closed this Aug 22, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.