Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

allows you to specify the ip spice/vnc listens on #100

Open
wants to merge 21 commits into from

7 participants

@joshie

use the option "listen-ip": "some.ip" in the vm json to change which ip the vnc/spice connection is listening on,
Note: will continue to use the previous behavior if this is not specified in the json.

@joshie joshie allows you to specify the ip spice/vnc listens on
use the option "listen-ip": "some.ip" in the vm json
84f8ac1
@rmustacc
Owner

Hi Josh, it doesn't appear that you have signed the CLA yet. Before we can take a look at this we'd need you to sign it. More information here: http://wiki.smartos.org/display/DOC/Contributing+to+SmartOS

@joshie

Hi, my company (Elysium Digital), has signed the CLA. I was told this was enough. Is this not accurate?

@rmustacc
Owner

Ah, yes, if they have, then that covers it. Sorry, there's not a good way to map github user to company.

@joshwilsdon joshwilsdon was assigned
@joshie

I wanted to ping on this. What do I need to do to get this accepted? I remember getting a list and forgetting it. Someone on the mailing list could apparently use this :)

@nshalman

To get this patch accepted should we rebase it to the current master branch?

JohnSonnenschein and others added some commits
@JohnSonnenschein JohnSonnenschein Merge pull request #164 from nshalman/update-grub-config
Add noinstall grub entry to build_iso
203cf1f
@joshwilsdon joshwilsdon OS-1669 make it possible to rotate log for running VM.js process dc1405c
@joshwilsdon joshwilsdon OS-1831 update platform bunyan to 0.18.1 1918ca1
@jperkin jperkin OS-1839: Improve imgadm install message 1b431c9
@rmustacc rmustacc OS-1798 ON build should use pkgsrc python c89b8c0
@joshwilsdon joshwilsdon OS-1842 switch to Logger.child() for VM actions. 3c5883a
@joshwilsdon joshwilsdon OS-1848 + OS-1849 fix validation on create-snapshot, fix tests for KVM. 84afd2a
@joshwilsdon joshwilsdon OS-1862 fix documentation for tests. e6fa542
@joshwilsdon joshwilsdon OS-1813 include files from /opt/custom/etc/rsyslog.d/ to extend rsysl…
…og config for GZ persistently.
e5047a1
@joshwilsdon joshwilsdon OS-1895 fix problems updating tmpfs when tmpfs size not specified at …
…create time.
5cc7c24
@joshwilsdon joshwilsdon OS-1881 force max_swap to always be >= 256M c0125d6
@joshwilsdon joshwilsdon OS-1864 don't accept invalid IP addresses. 6dd72b5
@joshwilsdon joshwilsdon OS-1900 fix dtrace-provider.js so correct binding is loaded. ee498b5
@joshwilsdon joshwilsdon OS-1902 fix problems with transition provisioning -> running when usi…
…ng nowait: true
32ff83f
@joshwilsdon joshwilsdon OS-1900 add test to ensure dtrace-provider keeps working correctly. 1648ce2
@joshwilsdon joshwilsdon OS-1903 add support for tracing timers in vmadmd. 29bcd96
@joshwilsdon joshwilsdon OS-1851 + OS-1730 VM.reboot should wait until zone is rebooted before…
… returning.
818bed5
@joshie joshie Merge branch 'listen_ip' of github.com:joshie/smartos-live into liste…
…n_ip

Conflicts:
	src/vm/node_modules/VM.js
16ba9b7
@joshie joshie allows you to specify the ip spice/vnc listens on
use the option "listen-ip": "some.ip" in the vm json
c121908
@joshie joshie Merge branch 'listen-ip' into listen_ip 29f35a3
@Licenser

bump, this would be a very welcome addition!

@nshalman

The hope is for this patch to be re-implemented after IPv6 support makes it into SmartOS.
In particular it really should get some error checking.
With this patch, (at least on the version of vmadmd on which it was implemented), if you specify an IP address that doesn't exist in the GZ, vmadmd crashes.
We get by by having automation code that makes sure everything is correct, but it would be better for vmadm to do the check and bail rather than create something that causes vmadmd to crash.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Jul 16, 2012
  1. @joshie

    allows you to specify the ip spice/vnc listens on

    joshie authored
    use the option "listen-ip": "some.ip" in the vm json
Commits on Jan 18, 2013
  1. @JohnSonnenschein

    Merge pull request #164 from nshalman/update-grub-config

    JohnSonnenschein authored
    Add noinstall grub entry to build_iso
Commits on Jan 22, 2013
  1. @joshwilsdon
Commits on Jan 23, 2013
  1. @joshwilsdon
Commits on Jan 24, 2013
  1. @jperkin
Commits on Jan 28, 2013
  1. @rmustacc
Commits on Jan 29, 2013
  1. @joshwilsdon
Commits on Feb 1, 2013
  1. @joshwilsdon
Commits on Feb 5, 2013
  1. @joshwilsdon
  2. @joshwilsdon

    OS-1813 include files from /opt/custom/etc/rsyslog.d/ to extend rsysl…

    joshwilsdon authored
    …og config for GZ persistently.
Commits on Feb 12, 2013
  1. @joshwilsdon
  2. @joshwilsdon
  3. @joshwilsdon
  4. @joshwilsdon
Commits on Feb 13, 2013
  1. @joshwilsdon
  2. @joshwilsdon
  3. @joshwilsdon
  4. @joshwilsdon
Commits on Feb 14, 2013
  1. @joshie

    Merge branch 'listen_ip' of github.com:joshie/smartos-live into liste…

    joshie authored
    …n_ip
    
    Conflicts:
    	src/vm/node_modules/VM.js
  2. @joshie

    allows you to specify the ip spice/vnc listens on

    joshie authored
    use the option "listen-ip": "some.ip" in the vm json
  3. @joshie
Something went wrong with that request. Please try again.