imgadm-repair destroys the imgadm database #130

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
3 participants
Contributor

MerlinDMC commented Oct 15, 2012

the variables in single-quotes don't get replaced so imgadm-repair writes ${manifest} into all json files which breaks everything else that should work with the file.

imgadm-repair tried to update locally imported manifest which are not found in the cache file - that would save an empty manifest file.

this pull request fixes #129

MerlinDMC added some commits Oct 15, 2012

imgadm-repair corrupts imgadm db
replacement of variables does not work in single-quotes and "imgadm get" should be "imgadm show"
do not update the json if the manifest was not found in the cache
this is true for all locally imported datasets

@ghost ghost assigned trentm Oct 18, 2012

Contributor

bahamas10 commented Sep 5, 2015

While this was clearly a bug, it looks like this script was removed in f729853

@MerlinDMC is this still relevant?

Contributor

MerlinDMC commented Sep 5, 2015

@bahamas10 if the script is gone this somewhat counts as "fixed" for me.

@MerlinDMC MerlinDMC closed this Sep 5, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment