Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
make joyent-minimal brand more flexible #339
joyent-minimal and joyent brands now share the
This is safe because the minimal brand overwrites the SMF repository of
This change allows a joyent-minimal zone to import any other service
referenced this pull request
Aug 13, 2014
added a commit
this pull request
Aug 13, 2014
I ran the test suite and found no new failures. I think we should be good to go.
Summary of testing on unmodified SmartOS (
Summary of testing on SmartOS with this patch applied (
Summary of failures (identical on both...):
Full vanilla test run output is here in case anyone wants to take a look at the failure details:
(I recommend running
After merging in OS-3338 I now only get 4 failures (they are presumably still unrelated, but in case @rgulewich want's to take a look...):
I built the SDC platform image with this patch applied, and then used that to assemble a headnode usb image.
I booted that headnode image and did an install and everything seems pretty happy.
I followed https://blog.shalman.org/running-sdc-coal-on-smartos/ but before booting I replaced the platform with my own platform including both this change and the Delphix vioif change (see joyent/sdc-manta#2 for a necessary workaround to get CoaL to cooperate with vioif).
I was able to get SDC and Manta installed.
Does that count as enough testing for this change?