New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

imgadm xz compression support for images #428

Closed
wants to merge 4 commits into
base: master
from

Conversation

Projects
None yet
5 participants
@xen0l
Contributor

xen0l commented Mar 24, 2015

This PR adds support for xz compressed images. @trentm what do you think about it?

@RSully

This comment has been minimized.

Show comment
Hide comment
@RSully

RSully Apr 5, 2015

Contributor

I'd love to see xz support.

Contributor

RSully commented Apr 5, 2015

I'd love to see xz support.

@bahamat

This comment has been minimized.

Show comment
Hide comment
@bahamat

bahamat Apr 5, 2015

Member

Related:

Xz support was added to the PI in joyent/illumos-extra@0f032ec.

Member

bahamat commented Apr 5, 2015

Related:

Xz support was added to the PI in joyent/illumos-extra@0f032ec.

@RSully

This comment has been minimized.

Show comment
Hide comment
@RSully

RSully Apr 5, 2015

Contributor

@bahamat looks like your illumos-extra link is dead from here.

Contributor

RSully commented Apr 5, 2015

@bahamat looks like your illumos-extra link is dead from here.

@bahamat

This comment has been minimized.

Show comment
Hide comment
@bahamat

bahamat Apr 5, 2015

Member

Thanks for letting me know. Fixed now.

Member

bahamat commented Apr 5, 2015

Thanks for letting me know. Fixed now.

@xen0l

This comment has been minimized.

Show comment
Hide comment
@xen0l

xen0l Apr 7, 2015

Contributor

Any progress on this?

Contributor

xen0l commented Apr 7, 2015

Any progress on this?

@bahamat

This comment has been minimized.

Show comment
Hide comment
@bahamat

bahamat Apr 7, 2015

Member

OS-4097 was released on 2015-04-02 so it may work already. Can you test on the new PI?

Member

bahamat commented Apr 7, 2015

OS-4097 was released on 2015-04-02 so it may work already. Can you test on the new PI?

@xen0l

This comment has been minimized.

Show comment
Hide comment
@xen0l

xen0l Apr 15, 2015

Contributor

Sorry for the delay, I will test this against the new version of PI, which is scheduled for tommorrow.

Contributor

xen0l commented Apr 15, 2015

Sorry for the delay, I will test this against the new version of PI, which is scheduled for tommorrow.

@xen0l

This comment has been minimized.

Show comment
Hide comment
@xen0l

xen0l Jul 25, 2015

Contributor

I tested this with the latest platform, which was released on 23.7.2015 and the tests for image creation passed. I had problems with installation though, but the problem was fixed in this repository and also submitted as a PR for the upsream repository (joyent/node-imgmanifest#2). Is there anything else left to do before this PR is accepted?

Contributor

xen0l commented Jul 25, 2015

I tested this with the latest platform, which was released on 23.7.2015 and the tests for image creation passed. I had problems with installation though, but the problem was fixed in this repository and also submitted as a PR for the upsream repository (joyent/node-imgmanifest#2). Is there anything else left to do before this PR is accepted?

@sjorge

This comment has been minimized.

Show comment
Hide comment
@sjorge

sjorge Aug 5, 2015

Contributor

@bahamat poke, still looks good to merge to me?

Contributor

sjorge commented Aug 5, 2015

@bahamat poke, still looks good to merge to me?

@xen0l

This comment has been minimized.

Show comment
Hide comment
@xen0l

xen0l Aug 17, 2015

Contributor

Just reminding myself. Having this accepted would be great. Is there anything else that should be done?
/cc @trentm @bahamat

Contributor

xen0l commented Aug 17, 2015

Just reminding myself. Having this accepted would be great. Is there anything else that should be done?
/cc @trentm @bahamat

@trentm

This comment has been minimized.

Show comment
Hide comment
@trentm

trentm Sep 1, 2015

Member

looking at it now. Sorry for dropping the ball.

Member

trentm commented Sep 1, 2015

looking at it now. Sorry for dropping the ball.

@trentm

This comment has been minimized.

Show comment
Hide comment
@trentm

trentm Sep 1, 2015

Member

Added https://smartos.org/bugview/OS-4690 to have a tracker ticket number for related changes (e.g. to node-imgmanifest.git).

Member

trentm commented Sep 1, 2015

Added https://smartos.org/bugview/OS-4690 to have a tracker ticket number for related changes (e.g. to node-imgmanifest.git).

@trentm trentm closed this Sep 1, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment