perf: cache repeat regexp processing for toShort#57
Merged
Conversation
Contributor
Author
|
Ping ... @caseyahenson as last repository commiter? Any chance this PR can be reviewed? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Caches the escaped search regex used in
ns.toShort, underunicodeCharRegexEscapedSearch(). This way each call totoShortdoesn't need to callns.escapeRegExponns.unicodeCharRegex().Additionally extracts the replacer function used in
str.replaceto a shared one - that way it can be used in bothns.toShortandns.replaceAll.@marvinhagemeister is the one who first prototyped these changes; we'd paired looking at https://github.com/JoshuaKGoldberg/repros/tree/draft-js-emoji-plugin-emoji-toolkit-performance. See #58 for more context.
Fixes #58
Co-authored-by: Marvin Hagemeister hello@marvinh.dev