Skip to content
This repository has been archived by the owner. It is now read-only.

emojify.run("that'd") == that':D #36

Closed
qq99 opened this issue Jun 22, 2014 · 4 comments · Fixed by #37
Labels
bug

Comments

@qq99
Copy link
Contributor

@qq99 qq99 commented Jun 22, 2014

emojify.run("that'd") == that':D
=> that':smile:

that'd may not be grammatical, but it should not be emojified :P

@qq99 qq99 changed the title emojify.run("that'd") == ':D emojify.run("that'd") == that':D Jun 22, 2014
@hassankhan hassankhan added the bug label Jun 23, 2014
@hassankhan

This comment has been minimized.

Copy link
Member

@hassankhan hassankhan commented Jun 23, 2014

That's weird, I'll try and have a look later this week.

@scripting

This comment has been minimized.

Copy link

@scripting scripting commented Jul 1, 2014

We're also having x-d rendered as an Emoji.

See this blog post for details.

http://virgin.smallpict.com/2014/07/01/sixdigit.html

We're using Emojify in Fargo.

Dave

@qq99

This comment has been minimized.

Copy link
Contributor Author

@qq99 qq99 commented Jul 13, 2014

@scripting my PR here #35 suggests that your issue should be fixed, are you sure you're using a more recent version of emojifyjs?

@qq99

This comment has been minimized.

Copy link
Contributor Author

@qq99 qq99 commented Jul 13, 2014

I've found out why my issue is occuring, and am working on a PR to prevent it.
Basically, I was trying to emojify the string I'd (the HTML escaped version of I'd), and it's matching the ;d

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants
You can’t perform that action at this time.