New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow keys of type "bytes" in Python 3 #39

Merged
merged 2 commits into from Sep 23, 2014

Conversation

Projects
None yet
3 participants
@cjlarose
Contributor

cjlarose commented Sep 21, 2014

Recall that in Python 2, bytes is just an alias for str, and is therefore a basestring. In Python 3, bytes is not a basestring, but still a perfectly acceptable input to hmac.new. The function prepare_HS_key as defined before, however, always assumed the key was a basestring. All tests pass in both Python 2.7 and Python 3.4.

jpadilla added a commit that referenced this pull request Sep 23, 2014

Merge pull request #39 from cjlarose/master
Allow keys of type "bytes" in Python 3

@jpadilla jpadilla merged commit 5bb8d3c into jpadilla:master Sep 23, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
@jpadilla

This comment has been minimized.

Show comment
Hide comment
@jpadilla
Owner

jpadilla commented Sep 23, 2014

@cjlarose thanks!

@jpadilla

This comment has been minimized.

Show comment
Hide comment
@jpadilla

jpadilla Sep 24, 2014

Owner

@progrium tagged and bumped up a new version that includes this. Should be ready to publish.

Owner

jpadilla commented Sep 24, 2014

@progrium tagged and bumped up a new version that includes this. Should be ready to publish.

@cjlarose

This comment has been minimized.

Show comment
Hide comment
@cjlarose

cjlarose Sep 25, 2014

Contributor

Sweet! Thanks!

Contributor

cjlarose commented Sep 25, 2014

Sweet! Thanks!

@cjlarose

This comment has been minimized.

Show comment
Hide comment
@cjlarose

cjlarose Oct 10, 2014

Contributor

Was this published to PyPi? Looks like 0.2.1 is the current version on the index instead of 0.2.2

Contributor

cjlarose commented Oct 10, 2014

Was this published to PyPi? Looks like 0.2.1 is the current version on the index instead of 0.2.2

@jpadilla

This comment has been minimized.

Show comment
Hide comment
@jpadilla

jpadilla Oct 10, 2014

Owner

@progrium can you publish latest version to PyPI? If you'd like to add me as a maintainer I could publish releases as well.

Owner

jpadilla commented Oct 10, 2014

@progrium can you publish latest version to PyPI? If you'd like to add me as a maintainer I could publish releases as well.

@progrium

This comment has been minimized.

Show comment
Hide comment
@progrium

progrium Oct 14, 2014

Contributor

Ah, that'd be helpful. What's your PyPI username?

On Fri, Oct 10, 2014 at 7:30 AM, José Padilla notifications@github.com
wrote:

@progrium https://github.com/progrium can you publish latest version to
PyPI? If you'd like to add me as a maintainer I could publish releases as
well.


Reply to this email directly or view it on GitHub
#39 (comment).

Jeff Lindsay
http://progrium.com

Contributor

progrium commented Oct 14, 2014

Ah, that'd be helpful. What's your PyPI username?

On Fri, Oct 10, 2014 at 7:30 AM, José Padilla notifications@github.com
wrote:

@progrium https://github.com/progrium can you publish latest version to
PyPI? If you'd like to add me as a maintainer I could publish releases as
well.


Reply to this email directly or view it on GitHub
#39 (comment).

Jeff Lindsay
http://progrium.com

@jpadilla

This comment has been minimized.

Show comment
Hide comment
@jpadilla

jpadilla Oct 14, 2014

Owner

@progrium my PyPI username is jpadilla

Owner

jpadilla commented Oct 14, 2014

@progrium my PyPI username is jpadilla

@progrium

This comment has been minimized.

Show comment
Hide comment
@progrium

progrium Oct 14, 2014

Contributor

Added! Release away.

On Tue, Oct 14, 2014 at 6:17 AM, José Padilla notifications@github.com
wrote:

@progrium https://github.com/progrium my PyPI username is jpadilla


Reply to this email directly or view it on GitHub
#39 (comment).

Jeff Lindsay
http://progrium.com

Contributor

progrium commented Oct 14, 2014

Added! Release away.

On Tue, Oct 14, 2014 at 6:17 AM, José Padilla notifications@github.com
wrote:

@progrium https://github.com/progrium my PyPI username is jpadilla


Reply to this email directly or view it on GitHub
#39 (comment).

Jeff Lindsay
http://progrium.com

@jpadilla

This comment has been minimized.

Show comment
Hide comment
@jpadilla

jpadilla Oct 16, 2014

Owner

@cjlarose released this as 0.2.3. Already on PyPI. Thanks again!

https://github.com/progrium/pyjwt/releases/tag/0.2.3

Owner

jpadilla commented Oct 16, 2014

@cjlarose released this as 0.2.3. Already on PyPI. Thanks again!

https://github.com/progrium/pyjwt/releases/tag/0.2.3

@cjlarose

This comment has been minimized.

Show comment
Hide comment
@cjlarose

cjlarose Oct 16, 2014

Contributor

Thanks!
On Oct 15, 2014 9:14 PM, "José Padilla" notifications@github.com wrote:

@cjlarose https://github.com/cjlarose released this as 0.2.3. Already
on PyPI. Thanks again!


Reply to this email directly or view it on GitHub
#39 (comment).

Contributor

cjlarose commented Oct 16, 2014

Thanks!
On Oct 15, 2014 9:14 PM, "José Padilla" notifications@github.com wrote:

@cjlarose https://github.com/cjlarose released this as 0.2.3. Already
on PyPI. Thanks again!


Reply to this email directly or view it on GitHub
#39 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment