Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow keys of type "bytes" in Python 3 #39

Merged
merged 2 commits into from Sep 23, 2014
Merged

Conversation

cjlarose
Copy link
Contributor

Recall that in Python 2, bytes is just an alias for str, and is therefore a basestring. In Python 3, bytes is not a basestring, but still a perfectly acceptable input to hmac.new. The function prepare_HS_key as defined before, however, always assumed the key was a basestring. All tests pass in both Python 2.7 and Python 3.4.

jpadilla added a commit that referenced this pull request Sep 23, 2014
Allow keys of type "bytes" in Python 3
@jpadilla jpadilla merged commit 5bb8d3c into jpadilla:master Sep 23, 2014
@jpadilla
Copy link
Owner

@cjlarose thanks!

@jpadilla
Copy link
Owner

@progrium tagged and bumped up a new version that includes this. Should be ready to publish.

@cjlarose
Copy link
Contributor Author

Sweet! Thanks!

@cjlarose
Copy link
Contributor Author

Was this published to PyPi? Looks like 0.2.1 is the current version on the index instead of 0.2.2

@jpadilla
Copy link
Owner

@progrium can you publish latest version to PyPI? If you'd like to add me as a maintainer I could publish releases as well.

@progrium
Copy link
Contributor

Ah, that'd be helpful. What's your PyPI username?

On Fri, Oct 10, 2014 at 7:30 AM, José Padilla notifications@github.com
wrote:

@progrium https://github.com/progrium can you publish latest version to
PyPI? If you'd like to add me as a maintainer I could publish releases as
well.


Reply to this email directly or view it on GitHub
#39 (comment).

Jeff Lindsay
http://progrium.com

@jpadilla
Copy link
Owner

@progrium my PyPI username is jpadilla

@progrium
Copy link
Contributor

Added! Release away.

On Tue, Oct 14, 2014 at 6:17 AM, José Padilla notifications@github.com
wrote:

@progrium https://github.com/progrium my PyPI username is jpadilla


Reply to this email directly or view it on GitHub
#39 (comment).

Jeff Lindsay
http://progrium.com

@jpadilla
Copy link
Owner

@cjlarose released this as 0.2.3. Already on PyPI. Thanks again!

https://github.com/progrium/pyjwt/releases/tag/0.2.3

@cjlarose
Copy link
Contributor Author

Thanks!
On Oct 15, 2014 9:14 PM, "José Padilla" notifications@github.com wrote:

@cjlarose https://github.com/cjlarose released this as 0.2.3. Already
on PyPI. Thanks again!


Reply to this email directly or view it on GitHub
#39 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants