Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Form Submit button styling broken #34

Closed
jpasholk opened this issue Oct 16, 2018 · 9 comments · Fixed by #36 or #37
Closed

Form Submit button styling broken #34

jpasholk opened this issue Oct 16, 2018 · 9 comments · Fixed by #36 or #37
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@jpasholk
Copy link
Owner

jpasholk commented Oct 16, 2018

When viewing the form on mobile, the styling is broken.

Browsers tested:

  • Safari
  • Chrome
  • Firefox
  • Brave

Screenshot of issue

@jpasholk jpasholk added this to the Jekyll-Uikit 1.0.0 milestone Oct 16, 2018
@jpasholk jpasholk added bug Something isn't working help wanted Extra attention is needed labels Oct 16, 2018
@jpasholk
Copy link
Owner Author

This may be a bug in UIKit itself.

@daviddarnes
Copy link
Contributor

Seems as though input elements with button classes applied don't get their appearance reset, the submit button needs -webkit-appearance: none to remove the odd looking iOS Safari styles

@jpasholk
Copy link
Owner Author

Would I use something like this?

input[type=submit] {
  -webkit-appearance: none;
}

Or use a class?

.button {
  -webkit-appearance: none;
}

I guess I could just try both, lol.

@daviddarnes
Copy link
Contributor

It’s the input one, but there’s no harm applying it to both. I would’ve made a pull request but I don’t know where to put these extra styles

@jpasholk
Copy link
Owner Author

It's in _includes/head.html! Maybe I should break that out into its own file now... lol

@daviddarnes
Copy link
Contributor

Probably should create a assets/css/theme-overrides.scss file

@jpasholk
Copy link
Owner Author

Hm, seems to be still broken here. Completely clueless here on how to fix it...

:(

@daviddarnes
Copy link
Contributor

Should be -webkit-appearance: none;

jpasholk pushed a commit that referenced this issue Oct 25, 2018
Hopefully closing #34
@jpasholk
Copy link
Owner Author

Yay! I fixed it with an inline style tag in the head... wtf tho man. lol

@daviddarnes daviddarnes mentioned this issue Oct 27, 2018
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
2 participants