Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

particleFlow_cfi re-organization? #57

Closed
hatakeyamak opened this issue Jul 11, 2019 · 3 comments
Closed

particleFlow_cfi re-organization? #57

hatakeyamak opened this issue Jul 11, 2019 · 3 comments
Labels
particleflow CMS Particle Flow Validation

Comments

@hatakeyamak
Copy link
Collaborator

hatakeyamak commented Jul 11, 2019

Now, we have some on-going discussion to reoptimize PFEGammaFilters parameters to find an optimized balance between tau and egamma needs. Then, when I looked at relatively long particleFlow_cfi.py, I was wondering if we can re-organize to make it easier to work with.

For example, introduce PSets such as:
PFEGammaFiltersParam
PFMuonAlgoParam
possibly also BadHcalTrackParam PSets
and put relevant parameter sets under them.

I think this will help egamma or muon people to focus only on parameters relevant for them.

Does this make sense? Is this something you can possibly look into? @guitargeek @jpata

Cc: @bendavid

@hatakeyamak
Copy link
Collaborator Author

hatakeyamak commented Jul 11, 2019

By the way, I am puzzled why this line is necessary:
https://cmssdt.cern.ch/lxr/source/RecoParticleFlow/PFProducer/python/particleFlowEGamma_cff.py#0007
when RecoParticleFlow/PFProducer/python/particleFlowEGamma_cfi.py doesn't really exist any longer. [but I see that, if I remove this line, step3 doesn't run.] I am obviously missing something.

@bendavid
Copy link

This file is automatically generated (by scram I think) based on the FillDescriptions in the corresponding C++ file.

@hatakeyamak
Copy link
Collaborator Author

I see.

https://github.com/hatakeyamak/cmssw/pull/new/Reconfigure_particleFlow_cfi
is the branch I created to take care of this. It also allowed me to spot a few config lines which are obsolete.

If it looks good to everybody here, I will make a PR tomorrow.

@jpata jpata added the particleflow CMS Particle Flow Validation label Oct 3, 2019
jpata pushed a commit that referenced this issue Feb 18, 2021
* Improve code that writes txt files for HLS

* CMS formatting

* CMS formatting

* CMS formatting

* format corrections
@jpata jpata closed this as completed Sep 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
particleflow CMS Particle Flow Validation
Projects
None yet
Development

No branches or pull requests

3 participants