Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more GS MIDI resets #29

Closed
freq-mod opened this issue Jun 12, 2021 · 6 comments
Closed

Add more GS MIDI resets #29

freq-mod opened this issue Jun 12, 2021 · 6 comments
Labels
enhancement New feature or request

Comments

@freq-mod
Copy link

The sequel to #24 - sometimes, MIDI program names still won't appear.
GSMIDI.zip - contain a few examples of such songs. Most of these should be Edirol SD-20/SC-8820, however PASSPORT.MID and CANYON.MID... aren't they plain SC-55 songs? Why is one instrument name not recognized?

@jpcima
Copy link
Owner

jpcima commented Jun 12, 2021

These do not have an explicit reset.
The best way to handle these is that the software scans the file for programs to match them against the database, and use this information to detect the midi specification.

@jpcima jpcima added the enhancement New feature or request label Jun 12, 2021
@jpcima
Copy link
Owner

jpcima commented Jun 14, 2021

Anyway, I should send systematically a reset before new tracks, because some of the synths have problems resetting with just the GM sequence.
So I'll do like this: if file lacks a reset sequence at the start, I'll scan the file to identify which MIDI spec it belongs to, and then I'll send the matching reset.

@jpcima
Copy link
Owner

jpcima commented Jun 14, 2021

This is supposed to be fixed in 00c609f.
Let me know if there are problems.

@freq-mod
Copy link
Author

I would say it's OK, yet one minor problem: MushiHS_Stage2.mid.zip

Channel 10 percussion set track name is blank, can anything de done about it?

@jpcima
Copy link
Owner

jpcima commented Jun 14, 2021

Done, the fall back will apply to percussion banks also

@freq-mod
Copy link
Author

Thanks! If I find a song that can't fall back, I will reopen this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants