Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TPC Register Issue (used in Street Fighter EX3) #688

Closed
ghost opened this issue Apr 23, 2018 · 8 comments
Closed

TPC Register Issue (used in Street Fighter EX3) #688

ghost opened this issue Apr 23, 2018 · 8 comments

Comments

@ghost
Copy link

ghost commented Apr 23, 2018

It appears to have a similar issue to the one pcsx2 used to have with the games cloth physics. I've linked to the original fix they did

PCSX2/pcsx2#1835

@jpd002
Copy link
Owner

jpd002 commented Apr 24, 2018

Cool! I'll need to make an hardware test out of that!

@ghost
Copy link
Author

ghost commented Apr 25, 2018

neat, glad that helps! Will your test possibly clarify the section he was unsure of with the TPC register? At any rate it's nice seeing more games working 😀

@jpd002
Copy link
Owner

jpd002 commented May 8, 2018

I've added the hardware test: unknownbrackets/ps2autotests@dd3671d.
Made the fix in the emulator: https://github.com/jpd002/Play-/tree/tpc_reg
The clothes in SFEX3 are better, but are still broken, probably due to VU flag issues. Going to merge the branch soon.

@jpd002 jpd002 changed the title Street Fighter EX3 TPC Register Issue (used in Street Fighter EX3) May 8, 2018
@ghost
Copy link

ghost commented May 8, 2018

And what about R racing evolution? It use this feature too.

Edit: The NTSC-J version of Street fighter ex3 use some CDVD flags, here is PCSX2 PR that fixed this version of the game: https://github.com/PCSX2/pcsx2/pull/1709/files

@jpd002
Copy link
Owner

jpd002 commented May 8, 2018

I don't have R Racing Evolution, but it might be interesting to try it.

Play! doesn't emulate the low level CDVD functions (everything's done through the HLE IOP modules), but it might interesting to try that version of the game to see if everything's ok.

@jpd002
Copy link
Owner

jpd002 commented May 9, 2018

Before:
sfex3_notpc
After:
sfex3_tpc

Closing this since it's now in master branch.

@jpd002 jpd002 closed this as completed May 9, 2018
@ghost
Copy link
Author

ghost commented May 9, 2018

Seems to be working properly at least from what I can see. Too bad about the graphical bugs though. Is the VU in charge of clipping the polygons in game or something? Ah I'm the one who opened the issue originally by the way

@jpd002
Copy link
Owner

jpd002 commented May 9, 2018

The VU micro program in SFEX3 is relying on the negative sticky flag and I don't think that's handled properly in the emulator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant