Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address deprecation of 'kubectl run' #396

Merged
merged 1 commit into from Nov 19, 2018

Conversation

Projects
None yet
2 participants
@jpetazzo
Copy link
Owner

jpetazzo commented Nov 1, 2018

kubectl run is being deprecated as a multi-purpose tool.
This PR replaces 'kubectl run' with 'kubectl create deployment'
in most places (except in the very first example, to reduce the
cognitive load; and when we really want a single-shot container).

It also updates the places where we use a 'run' label, since
'kubectl create deployment' uses the 'app' label instead.

NOTE: this hasn't gone through end-to-end testing yet.

Successfully tested on a 3-node Ubuntu 16.04 cluster ;-)

Address deprecation of 'kubectl run'
kubectl run is being deprecated as a multi-purpose tool.
This PR replaces 'kubectl run' with 'kubectl create deployment'
in most places (except in the very first example, to reduce the
cognitive load; and when we really want a single-shot container).

It also updates the places where we use a 'run' label, since
'kubectl create deployment' uses the 'app' label instead.

NOTE: this hasn't gone through end-to-end testing yet.
@bridgetkromhout

This comment has been minimized.

Copy link
Collaborator

bridgetkromhout commented Nov 7, 2018

Looks good - I'll test but probably not until Friday.

@jpetazzo

This comment has been minimized.

Copy link
Owner Author

jpetazzo commented Nov 13, 2018

I happily report that the flow was 💯

@bridgetkromhout

This comment has been minimized.

Copy link
Collaborator

bridgetkromhout commented Nov 19, 2018

Haven't had time to test this, and probably won't soon, but it sounds good to me.

@bridgetkromhout bridgetkromhout merged commit 5fad84a into master Nov 19, 2018

1 check passed

deploy/netlify Deploy preview ready!
Details

@jpetazzo jpetazzo deleted the kubectl-create-deployment branch Dec 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.