Permalink
Commits on Aug 13, 2016
  1. Merge pull request #550 from brianmuse/feature/more-efficient-eager-l…

    …oading
    
    Feature: Faster Eager Loading
    committed on GitHub Aug 13, 2016
Commits on Aug 11, 2016
  1. @brianmuse
  2. @brianmuse

    Improve eager loading efficiency from `O(n*m)` to `O(m) + O(n*log(m))…

    …` (not including the `in_array` improvement)
    brianmuse committed Aug 11, 2016
Commits on Jul 13, 2016
  1. @louismrose @koenpunt

    Add info on skipped tests and how to fix them (#547)

    * Add info on skipped tests and how to fix them
    
    * Detail PHPAR env vars in contribution docs.
    
    * Clarifies that brew commands are for macOS
    louismrose committed with koenpunt Jul 13, 2016
Commits on Jul 11, 2016
  1. @Rican7

    Merge pull request #549 from fetch/cache-exception

    Cache exception
    Rican7 committed on GitHub Jul 11, 2016
  2. @koenpunt
Commits on Jun 22, 2016
  1. @kilida @koenpunt

    Duplicate conditional expression in Validations.php (#545)

    `!is_string($options['with'])` is repeated.
    kilida committed with koenpunt Jun 22, 2016
Commits on Jun 7, 2016
  1. Merge pull request #541 from Rican7/bugfix/datetime-cloning

    Bugfix - DateTime cloning and model attribute dirty flagging
    committed Jun 7, 2016
Commits on Jun 6, 2016
  1. @Rican7
  2. @Rican7

    Implementing the `__clone()` method with the

    proper model dereferencing logic
    Rican7 committed Jun 6, 2016
  3. @Rican7

    Clarification of test flow

    Rican7 committed Jun 6, 2016
  4. @Rican7
Commits on May 20, 2016
  1. Merge pull request #540 from jpfuentes2/test_new_phpunit

    Upgrading phpunit, wow we're way behind
    committed May 20, 2016
  2. Upgrading phpunit, wow we're way behind

    committed May 19, 2016
  3. Merge pull request #539 from Rican7/bugfix/timezone-regression

    Bugfix - Explicit Time Zone assignment regression from #532
    committed May 20, 2016
Commits on May 19, 2016
  1. @Rican7

    PHPUnit 3.7 can't correctly compare DateTime

    objects with different TZs
    Rican7 committed May 19, 2016
  2. @Rican7

    Now using the shared constant for a less error

    prone reusability and easier cross-class documentation
    Rican7 committed May 19, 2016
  3. @Rican7

    Fixing the issue in "Connection" too while making

    a common constant for later reference.
    Rican7 committed May 19, 2016
  4. @Rican7

    The `ActiveRecord\DateTime::createFromFormat()`

    wasn't passing in the timezone. Fixing...
    Rican7 committed May 19, 2016
  5. @Rican7
  6. @Rican7

    Fixing the format used when converting `DateTime`

    instances
    Rican7 committed May 19, 2016
  7. @Rican7
Commits on May 16, 2016
  1. @koenpunt

    add test for CacheException

    koenpunt committed May 16, 2016
  2. @koenpunt

    Add CacheException class

    this class is already in use in the cache class
    koenpunt committed May 16, 2016
Commits on Apr 23, 2016
  1. @MasonM @koenpunt

    Add support for using a custom Date class (#532)

    If your project uses a date library that doesn't extend \DateTime (e.g. Zend_Date), then you
    currently have to convert to and from ActiveRecord\DateTime when interacting with models, which is a
    pain and error prone. We've had to fix quite a number of bugs due to missing conversions. This
    commit removes the need for that by adding support for using a custom date class.
    
    The custom class is set in ActiveRecord\Config, which uses similar logic to the logger methods for
    the getter and setter. The ActiveRecord\Config->set_date_class() method checks if the provided class
    has "format" and "createFromFormat" methods, which are all that are required.
    
    I changed everything that created new date objects to use "createFromFormat()" instead of the
    constructor, because many date libraries don't accept a date string in the constructor. Besides, I
    think createFromFormat() is better in general because it's more explicit.
    
    For the "attribute_of" method, I made that an optional feature by introducing an interface that
    defines it, which ActiveRecord\Model->assign_attribute() checks for. The reason I made this optional
    is because if you use an immutable date class (e.g. PHP's DateTimeImmutable), you don't need to
    worry about the dirty flagging, so there's no need to have that method.
    MasonM committed with koenpunt Apr 23, 2016
Commits on Apr 22, 2016
  1. Merge pull request #517 from ghost/master

    Update for PHP 7 Array to string Exception
    committed Apr 22, 2016
  2. Merge pull request #533 from srsbiz/copy-timezone

    Copy exact timezone from \DateTime object
    committed Apr 22, 2016
  3. Merge pull request #505 from ftwbzhao/master

    [utils]update plural regular
    committed Apr 22, 2016
Commits on Apr 11, 2016
  1. @koenpunt

    Create .editorconfig (#534)

    koenpunt committed Apr 11, 2016
Commits on Apr 7, 2016
  1. @shaneiseminger @koenpunt

    Override additional DateTime methods

    * Override additional DateTime methods
    
    * Call DateTime methods directly, return values for method chaining
    
    * Change signature, fix test
    
    * Fixes to DateTime method defaults
    shaneiseminger committed with koenpunt Apr 7, 2016
Commits on Apr 5, 2016
  1. @srsbiz
Commits on Mar 29, 2016
  1. @koenpunt

    Merge pull request #531 from jihunleekr/master

    Remove unnecessary conversion (DateTime)
    koenpunt committed Mar 29, 2016
  2. @jihunleekr
Commits on Mar 4, 2016
  1. Merge pull request #524 from ftwbzhao/patch-2

    fix code annotation
    committed Mar 4, 2016
Commits on Mar 2, 2016
  1. @ftwbzhao

    fix code annotation

    ftwbzhao committed Mar 2, 2016