MySQL ids should be unsigned ints #157

Closed
wants to merge 1 commit into
from

5 participants

@felixmiddendorf

MySQL primary keys should be unsigned integers to make better use of the integer space (ids are > 0 anyway).

@jchook

+1

@elliot-sawyer

Totally agree with this, standard practice for me. How would it behave with non-MySQL databases?

@sc68cal

I've never heard of using negative integers for IDs. I think it will be a safe change.

@felixmiddendorf

@luminairex My pull request only affects the MysqlAdapter, so side-effects should not be an issue.
See: https://github.com/kla/php-activerecord/pull/157/files

@cvanschalkwijk
Collaborator

Thanks, merged.

@felixmiddendorf

Cool, thank you very much :).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment