separate connection string parsing from connection #494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lib/Connection.php
Outdated
| throw new DatabaseException("Empty connection string"); | ||
| { | ||
| $connection_info = new ConnectionInfo($connection_info_or_name); | ||
| } |
There was a problem hiding this comment.
Why not add in a block that checks if the $connection_info_or_name is an instance of the ConnectionInfo class? That way you can pass around the value object directly and it doesn't have to be re-built each time.
There was a problem hiding this comment.
Yeah I'm still not happy with the if/else logic in this function anyways.
koenpunt
force-pushed
the
array-connection-info
branch
2 times, most recently
from
0ffaef0
to
db0009b
Compare
|
@Rican7 I've updated a lot. In need of some doc-block updates here and there but I think this should be alright. |
| { | ||
| return new ConnectionInfo($connection); | ||
| } | ||
| }, $connections); |
There was a problem hiding this comment.
Oo, nice. Good call on building them here too.
|
@jpfuentes2 any word on this? |
koenpunt
force-pushed
the
array-connection-info
branch
2 times, most recently
from
33a23bb
to
d5cd8ee
Compare
koenpunt
force-pushed
the
1.1-dev
branch
2 times, most recently
from
494d55e
to
352e1b6
Compare
parse_str is about 60% faster than custom parsing using foreach loop
sscanf is about 40% faster than using a regex
code formatting
koenpunt
force-pushed
the
array-connection-info
branch
from
d5cd8ee
to
4507f7f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add support for connection details as array
Solution for #315
NB this is a pull request to the 1.1-dev branch