Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Support for popout chat #85

Closed
silverwind opened this Issue Mar 5, 2014 · 5 comments

Comments

Projects
None yet
4 participants

Popout chat support would be great!

Looks like a simple change to @include is all that's needed.

@jpgohlke jpgohlke added the enhancement label Mar 6, 2014

@hugomg hugomg added bug and removed enhancement labels Mar 6, 2014

Collaborator

hugomg commented Mar 6, 2014

I'm reclassifying this as a bug - the script was already supposed to work with the popout chat and even had the the @includes for it.

Unfortunately, I can't test it myself right now. Is this just a greasemonkey loading issue (meaning that the script runs correctly if you paste it into the console and it would just be a matter of updating the @include urls) or did one of the recent updates (to the script or to twitch itself) break the script?

It's because twitch changed their URL, from

http://beta.twitch.tv/twitchplayspokemon/chat?popout=&secret=safe

to

http://www.twitch.tv/twitchplayspokemon/chat?popout=&secret=safe

I'm not sure they use the beta URL still, might be worth keeping it around for a while.

Collaborator

Zephymastyx commented Mar 6, 2014

This only affects the userscript version,correct? Works perfectly fine for me.
As I don't use that version, can you confirm it works when you replace the @include? You can paste chat_filter.user.js in your console instead of the loader to test changes easily.

Yeah, it's only for the userscript. I'd suggest making the include lines more flexible by replacing them with a regex. This one works fine for me:

// @include     /^https?://(www|beta)\.twitch\.tv\/.*twitchplayspokemon.*/

@hugomg hugomg added a commit to hugomg/twitch-chat-filter that referenced this issue Mar 7, 2014

@hugomg hugomg Fix greasemonkey not recognizing popout chat
Now the @include directive uses a single regex that should
automatically cover all the cases.

Fixes #85
785db16

@Zephymastyx Zephymastyx referenced this issue Mar 7, 2014

Merged

3 new options #88

@jpgohlke jpgohlke added the completed label Apr 18, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment