Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Windows build in Go 1.19 #4

Closed
jpillora opened this issue Feb 21, 2023 · 6 comments
Closed

Fix Windows build in Go 1.19 #4

jpillora opened this issue Feb 21, 2023 · 6 comments
Labels

Comments

@jpillora
Copy link
Owner

jpillora commented Feb 21, 2023

hey @Fusion, i needed to update deps to get latest Go ssh.

Moving up to Go 1.19 brakes only in windows. could you please check out:
https://github.com/jpillora/sshd-lite/actions/runs/4232344720/jobs/7351964766

Will try to release with 1.17 for now... 06b36a6

jpillora added a commit that referenced this issue Feb 21, 2023
@jpillora jpillora added the bug label Feb 21, 2023
@jpillora
Copy link
Owner Author

jpillora commented Feb 24, 2023

No rush, I can comment out the windows builds for future releases

@Fusion
Copy link
Contributor

Fusion commented Feb 24, 2023

OK I'l take a look. I was going to check it today but, no. Today is the day that I stupidly delete my dev VMs!

@jpillora
Copy link
Owner Author

jpillora commented Feb 24, 2023 via email

@Fusion
Copy link
Contributor

Fusion commented Feb 27, 2023

As you can see, I created a new pull request. As you can also see, it breaks sshd-lite's CI, which still relies on Go 1.17.
I had to work around a breaking change in Go's internal API between both releases.
Makes sense that 1.17 would not like what I did.
Are you ok with only supporting Go 1.19+ or do you need backward compatibility? (I may be able to figure something out)

@jpillora
Copy link
Owner Author

hey @Fusion I'm happy to drop pre 1.19 support and go ahead with the windows fix (I am in sudden need to use a windows machine – unfortunately 😁)

@jpillora
Copy link
Owner Author

jpillora commented Jan 5, 2024

Closed in 6e023d9

@jpillora jpillora closed this as completed Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants