New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Windows build in Go 1.19 #4
Comments
|
No rush, I can comment out the windows builds for future releases |
|
OK I'l take a look. I was going to check it today but, no. Today is the day that I stupidly delete my dev VMs! |
|
Haha great timing
…On Fri, 24 Feb 2023 at 2:03 pm Chris F Ravenscroft ***@***.***> wrote:
OK I'l take a look. I was going to check it today but, no. Today is the
day that I stupidly delete my dev VMs!
—
Reply to this email directly, view it on GitHub
<#4 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAE2X4ZS7ZFGZLR63VUMFF3WZAQJ5ANCNFSM6AAAAAAVC6U4MM>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
As you can see, I created a new pull request. As you can also see, it breaks sshd-lite's CI, which still relies on Go 1.17. |
|
hey @Fusion I'm happy to drop pre 1.19 support and go ahead with the windows fix (I am in sudden need to use a windows machine – unfortunately 😁) |
|
Closed in 6e023d9 |
hey @Fusion, i needed to update deps to get latest Go ssh.
Moving up to Go 1.19 brakes only in windows. could you please check out:
https://github.com/jpillora/sshd-lite/actions/runs/4232344720/jobs/7351964766
Will try to release with 1.17 for now... 06b36a6
The text was updated successfully, but these errors were encountered: