Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small fix for rename/delete edge cases #4

Merged
merged 2 commits into from Apr 8, 2021
Merged

Conversation

luckman212
Copy link
Contributor

@luckman212 luckman212 commented Apr 6, 2021

Hey @jplattel 👋

This small PR fixes 2 edge cases:

  1. non-active file renamed from the side panel incorrectly sets the title of the active document
  2. deleting non-active file causes title to revert to default even if there is still an open note

(thanks to @pjeby for inspiration from ravimashru/obsidian-show-file-path@59c49b7)

@luckman212
Copy link
Contributor Author

@luckman212 luckman212 commented Apr 6, 2021

Sorry for the README.md in here. I copied in the original from your main but not sure how to just remove it completely from the branch changes. Hope it's ok.

@jplattel
Copy link
Owner

@jplattel jplattel commented Apr 8, 2021

Awesome! Thanks @luckman212! Looks good, I'll merge it 👍

@jplattel jplattel merged commit 5b9b804 into jplattel:main Apr 8, 2021
@luckman212
Copy link
Contributor Author

@luckman212 luckman212 commented Apr 8, 2021

Thanks @jplattel - how does the releasing work? Will it auto update on the Obsidian community repo?

@jplattel
Copy link
Owner

@jplattel jplattel commented Apr 8, 2021

I just need to set a tag, which I'm about to do, it should roll out to Obsidian after that :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants