Recovering from "flash reset" does not restore volume #52

Closed
marcn opened this Issue Sep 16, 2011 · 4 comments

Comments

Projects
None yet
2 participants
@marcn

marcn commented Sep 16, 2011

When the Flash solution is being used and a "flash reset" is encountered, the library handles it by reloading the media and setting the playhead to the last position (playing if it was already playing). However it doesn't restore the volume setting.

marcn added a commit to Pandora-Radio/jPlayer that referenced this issue Sep 16, 2011

@ghost

This comment has been minimized.

Show comment Hide comment
@ghost

ghost Sep 17, 2011

Contributor

Yep, you are right. The volume would be restored to the original option setting of the volume.

I'll add this correction.

Contributor

ghost commented Sep 17, 2011

Yep, you are right. The volume would be restored to the original option setting of the volume.

I'll add this correction.

@marcn

This comment has been minimized.

Show comment Hide comment
@marcn

marcn Sep 20, 2011

Looking at the code, could there also be an edge case where currentTime == 0 but paused == false (i.e. the audio was "played" but the playhead had not yet advanced, perhaps because it was still loading)? In this case, it seems like it would fail to re-play the audio.

marcn commented Sep 20, 2011

Looking at the code, could there also be an edge case where currentTime == 0 but paused == false (i.e. the audio was "played" but the playhead had not yet advanced, perhaps because it was still loading)? In this case, it seems like it would fail to re-play the audio.

@ghost

This comment has been minimized.

Show comment Hide comment
@ghost

ghost Nov 6, 2013

Contributor

Gah! I never added that fix. I'm doing it now.
So that was a commit reference, not a Pull Request... Think that was why I missed it.

In practice, Firefox now has that problem fixed. The flash is no longer ripped from the page and slapped back into it when doing CSS changes like position:fixed;

Contributor

ghost commented Nov 6, 2013

Gah! I never added that fix. I'm doing it now.
So that was a commit reference, not a Pull Request... Think that was why I missed it.

In practice, Firefox now has that problem fixed. The flash is no longer ripped from the page and slapped back into it when doing CSS changes like position:fixed;

ghost pushed a commit that referenced this issue Nov 6, 2013

@ghost

This comment has been minimized.

Show comment Hide comment
@ghost

ghost Nov 6, 2013

Contributor

Fix applied to dev branch.

Release note:
[dev] Bug Fix: The volume was not restored after a flashreset event. This fix was given here Recovering from "flash reset" does not restore volume by marcn.

Contributor

ghost commented Nov 6, 2013

Fix applied to dev branch.

Release note:
[dev] Bug Fix: The volume was not restored after a flashreset event. This fix was given here Recovering from "flash reset" does not restore volume by marcn.

@ghost ghost closed this Nov 6, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment