Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Some query lines sent again and again #6
I was able to track this down a bit more.
Upon connecting to znc, a client will receive the last line of every past query. If it was an incoming message, all clients will pop up a query window and show it. If it was an outgoing message though, only those clients who understand this will do it (which rules out mIRC). So I am assuming for queries the start index is off by one or something.
Hi! I'm using ZNC 1.6.2 and latest ClientBuffer (I installed everything yesterday!). Everything works as expected for channels, but in query dialogs I also receive the same message everytime I reconnect. Please note that at the moment I'm only connected from the same client (Textual on Mac), but I can try from another PC (Linux using XChat) if you want.
It seems you can do
I think there is no easy solution for repeating/missing lines without extending cmodule API. The API seems to not provide callback for sent messages with the same timestamps which are used in replay buffer callbacks. That's probably why clientbuffer uses it's own timestamps and that can be cause of trouble I think. Another issue could be the conversion from timeval to double and then back. But I think the main problem is there is currently no way how to identify which messages were already sent to client.
referenced this issue
Aug 31, 2016
added a commit
Apr 27, 2017
I noticed that ZNC 1.7 adds some new module APIs:
These new APIs provide a CMessage, which makes a timestamp available through the GetTime function.
I think using these should eliminate the problem described in this issue.
Implemented ZNC 1.7 support in my fork here:
Seems to work perfectly according to my testing.
If you use ZNC 1.7, you could give it a try.