Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs to explain whether move supports directories as destination #830

Closed
Pomax opened this issue Aug 20, 2020 · 2 comments
Closed

Add docs to explain whether move supports directories as destination #830

Pomax opened this issue Aug 20, 2020 · 2 comments

Comments

@Pomax
Copy link

@Pomax Pomax commented Aug 20, 2020

Given that mv somefile.txt textfiles will happily move a file somefile.txt into a dir textfiles, one might expect move('somefile.txt', 'textfiles') to work, but the docs currently do not explain what a valid dest is. Could the docs be amended to make it explicit whether dest must be a file path, or whether any path is valid?

@RyanZim
Copy link
Collaborator

@RyanZim RyanZim commented Aug 20, 2020

Sure, PR welcome.

@Pomax
Copy link
Author

@Pomax Pomax commented Aug 22, 2020

Just a friendly reminder that "PRs welcome" isn't really the best phrase to use. To people who file issues, it's effectively a polite way to say "if you want this, go do it yourself", and is one of those phrases that seemed like a good idea when it first popped up, but actually hurts a project more than it helps. A "Good idea!" response and then setting some labels like "docs", "enhancement", and "help wanted" to signal this probably won't get done by the core team itself unless someone has a spare moment is by far the more welcoming approach.

(I will unfortunately not be filing that PR: I'm weeks deep into a 100+ page open source project documentation rewrite already, and have enough on my plate that filing docs improvement requests is the best I can do right now)

RyanZim added a commit that referenced this issue Apr 15, 2021
Fixes #830
@RyanZim RyanZim closed this in #888 Apr 17, 2021
RyanZim added a commit that referenced this issue Apr 17, 2021
Fixes #830
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

3 participants
@Pomax @RyanZim and others