Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests on Node 14 #800

Merged
merged 2 commits into from May 14, 2020
Merged

Fix tests on Node 14 #800

merged 2 commits into from May 14, 2020

Conversation

RyanZim
Copy link
Collaborator

@RyanZim RyanZim commented May 14, 2020

Fixes #798

writeFileSync requires a data parameter

Also add Node 14 to CI

@RyanZim RyanZim requested a review from manidlou May 14, 2020
@manidlou
Copy link
Collaborator

manidlou commented May 14, 2020

@RyanZim thank you for taking care of this quickly! I think the issue number in description should be #798?!

RyanZim added 2 commits May 14, 2020
Fixes #798

writeFileSync requires a data parameter
@RyanZim
Copy link
Collaborator Author

RyanZim commented May 14, 2020

@manidlou Good catch, updated, and forced-pushed to fix commit message as well.

@RyanZim RyanZim merged commit 28173ed into master May 14, 2020
4 checks passed
@RyanZim RyanZim deleted the ryan/fix-tests-14 branch May 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants