Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Browse files

Change 26f4c91 broke Rake task's RCov support. Fixed.

  • Loading branch information...
commit 400c8b8d45eeab4a2c0c2b73d0c951d5c3f5cdde 1 parent f9d71b7
@jpshackelford authored
Showing with 23 additions and 1 deletion.
  1. +1 −1  lib/cucumber/rake/task.rb
  2. +22 −0 spec/cucumber/rake/task_spec.rb
View
2  lib/cucumber/rake/task.rb
@@ -167,7 +167,7 @@ def define_task #:nodoc:
def runner(task_args = nil) #:nodoc:
cucumber_opts = [(ENV['CUCUMBER_OPTS'] ? ENV['CUCUMBER_OPTS'].split(/\s+/) : nil) || cucumber_opts_with_profile]
if(@rcov)
- RCovCucumberRunner.new(libs, binary, cucumber_opts, feature_files, bundler, rcov_opts)
+ RCovCucumberRunner.new(libs, binary, cucumber_opts, bundler, feature_files, rcov_opts)
elsif(@fork)
ForkedCucumberRunner.new(libs, binary, cucumber_opts, bundler, feature_files)
else
View
22 spec/cucumber/rake/task_spec.rb
@@ -0,0 +1,22 @@
+require File.expand_path(File.dirname(__FILE__) + '/../../spec_helper')
+require 'cucumber/rake/task'
+require 'rake'
+
+module Cucumber
+ module Rake
+
+ describe Task do
+
+ context "when running rcov" do
+ let(:task) { Task.new { |t| t.rcov = true } }
+
+ it "correctly builds an RCovCucumberRunner" do
+ runner = task.runner
+ runner.should be_a(Task::RCovCucumberRunner)
+ end
+
+ end
+ end
+
+ end
+end

1 comment on commit 400c8b8

@aslakhellesoy

Good catch and fix. I got cross-eyed there it seems.

Please sign in to comment.
Something went wrong with that request. Please try again.