New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the Yaml and SWXMLHash frameworks to address issue #232. #233

Merged
merged 1 commit into from Aug 21, 2016

Conversation

Projects
None yet
3 participants
@owensd
Copy link
Contributor

owensd commented Jul 31, 2016

This partially addresses issue #232.

I'm a little confused though as I'm not seeing a Carthage.zip file being produced. I do see a SourceKittenFramework.framework.zip file though.

@jpsim

This comment has been minimized.

Copy link
Owner

jpsim commented Aug 21, 2016

Hi @owensd, I'm very very sorry for the long delay in getting back to you on this.

Due to packaging changes in #215, make archive no longer includes dependencies 😞. I hadn't noticed since we haven't cut a release since that was merged.

If I download SourceKittenFramework.framework.zip from the last release (0.13), I get this:

tree -d ~Downloads/Carthage/Build/Mac/SourceKittenFramework.framework 
~/Downloads/Carthage/Build/Mac/SourceKittenFramework.framework
├── Headers -> Versions/Current/Headers
├── Modules -> Versions/Current/Modules
├── Resources -> Versions/Current/Resources
└── Versions
    ├── A
    │   ├── Frameworks
    │   │   ├── Commandant.framework
    │   │   │   ├── Resources -> Versions/Current/Resources
    │   │   │   └── Versions
    │   │   │       ├── A
    │   │   │       │   └── Resources
    │   │   │       └── Current -> A
    │   │   ├── Result.framework
    │   │   │   ├── Resources -> Versions/Current/Resources
    │   │   │   └── Versions
    │   │   │       ├── A
    │   │   │       │   └── Resources
    │   │   │       └── Current -> A
    │   │   ├── SWXMLHash.framework
    │   │   │   ├── Resources -> Versions/Current/Resources
    │   │   │   └── Versions
    │   │   │       ├── A
    │   │   │       │   └── Resources
    │   │   │       └── Current -> A
    │   │   └── Yaml.framework
    │   │       ├── Resources -> Versions/Current/Resources
    │   │       └── Versions
    │   │           ├── A
    │   │           │   └── Resources
    │   │           └── Current -> A
    │   ├── Headers
    │   ├── Modules
    │   │   └── SourceKittenFramework.swiftmodule
    │   └── Resources
    └── Current -> A

35 directories

whereas if I run make archive from master today, I get this:

$ tree -d Carthage/Build/Mac/SourceKittenFramework.framework
Carthage/Build/Mac/SourceKittenFramework.framework
├── Headers -> Versions/Current/Headers
├── Modules -> Versions/Current/Modules
├── Resources -> Versions/Current/Resources
└── Versions
    ├── A
    │   ├── Headers
    │   ├── Modules
    │   │   └── SourceKittenFramework.swiftmodule
    │   └── Resources
    └── Current -> A

10 directories

I'll accept this patch because you're right that things are currently broken and this helps, but I'd love to hear if @norio-nomura, who did #215, has better ideas.

I'm a little confused though as I'm not seeing a Carthage.zip file being produced. I do see a SourceKittenFramework.framework.zip file though.

I guess I'm confused why you're expecting to see a Carthage.zip file. We package SourceKittenFramework as SourceKittenFramework.framework.zip in releases.

@jpsim jpsim merged commit 2440274 into jpsim:master Aug 21, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@norio-nomura

This comment has been minimized.

Copy link
Collaborator

norio-nomura commented Aug 22, 2016

Sorry, I didn't think about binary distribution of SourceKittenFramework at all. 😞

@norio-nomura

This comment has been minimized.

Copy link
Collaborator

norio-nomura commented Aug 22, 2016

I think /usr/local/Frameworks/SourceKittenFramework.framework is not usable for developing another applications that depends on SourceKittenFramework.framework.
Those applications should distribute SourceKittenFramework.framework contained into their distribution.

SourceKittenFramework.framework.zip in GitHub Release is downloaded by Carthage when user choose using binary distribution of frameworks.
When using SourceKittenFramework by carthage, carthage bootstrap will also build SWXMLHash.framework and Yaml.framework as following:

➜  22:10:18  echo 'github "jpsim/SourceKitten"'>Cartfile
➜  22:12:40  DEVELOPER_DIR=/Applications/Xcode.app carthage bootstrap
*** Checking out SWXMLHash at "2.5.0"
*** Downloading SourceKitten.framework binary at "0.13.0: FormatKitten"
*** Checking out YamlSwift at "eecbc9108c297f3faf946504b648b0a7368b0f4d"
*** xcodebuild output can be found in /var/folders/kt/2mwy9b_56_7993x190pl_1fh0000gn/T/carthage-xcodebuild.8lPZVc.log
*** Building scheme "SWXMLHash watchOS" in SWXMLHash.xcworkspace
*** Building scheme "SWXMLHash iOS" in SWXMLHash.xcworkspace
*** Building scheme "SWXMLHash tvOS" in SWXMLHash.xcworkspace
*** Building scheme "SWXMLHash OSX" in SWXMLHash.xcworkspace
*** Building scheme "Yaml tvOS" in Yaml.xcodeproj
*** Building scheme "Yaml iOS" in Yaml.xcodeproj
*** Building scheme "Yaml OSX" in Yaml.xcodeproj

Containing SWXMLHash and Yaml into SourceKittenFramework.framework.zip will cause overwriting built by downloaded or downloaded by built. I don't know that would cause some issue.

@owensd

This comment has been minimized.

Copy link
Contributor

owensd commented Aug 22, 2016

I guess I'm confused why you're expecting to see a Carthage.zip file. We package SourceKittenFramework as SourceKittenFramework.framework.zip in releases.

This might have been just my misreading of Releasing.md.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment