From 6139daa2b73748042799a21f84d2fe5f03a0400f Mon Sep 17 00:00:00 2001 From: JP Simard Date: Wed, 18 Oct 2023 19:50:56 -0400 Subject: [PATCH] Use for-in instead of while true --- .../Sources/PitchRecording/PitchRecording.swift | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/Packages/MicrophonePitchDetector/Sources/PitchRecording/PitchRecording.swift b/Packages/MicrophonePitchDetector/Sources/PitchRecording/PitchRecording.swift index af76471..dd2653b 100644 --- a/Packages/MicrophonePitchDetector/Sources/PitchRecording/PitchRecording.swift +++ b/Packages/MicrophonePitchDetector/Sources/PitchRecording/PitchRecording.swift @@ -35,21 +35,17 @@ public struct PitchRecording: Codable, Equatable { let tracker = PitchTracker(sampleRate: Int32(buffer.format.sampleRate)) - var iteration = 0 var pitchRecording = PitchRecording() - while true { + for iteration in 0... { do { try file.read(into: buffer) + let pitch = tracker.getPitch(from: buffer, amplitudeThreshold: 0.05) + let entry = PitchRecording.Entry(iteration: iteration, pitch: pitch) + pitchRecording.entries.append(entry) } catch { break } - - let pitch = tracker.getPitch(from: buffer, amplitudeThreshold: 0.05) - let entry = PitchRecording.Entry(iteration: iteration, pitch: pitch) - pitchRecording.entries.append(entry) - iteration += 1 } - return pitchRecording } }