From dd2697853608d3a74a06de0f3b321bd9166ad13e Mon Sep 17 00:00:00 2001 From: Liuchy1 Date: Thu, 17 Mar 2016 13:52:33 +0800 Subject: [PATCH] fix device client and add test --- .../java/cn/jpush/api/device/DeviceClient.java | 2 -- .../jpush/api/device/DeviceNormalRemoteTest.java | 15 +++++++++++++++ 2 files changed, 15 insertions(+), 2 deletions(-) diff --git a/src/main/java/cn/jpush/api/device/DeviceClient.java b/src/main/java/cn/jpush/api/device/DeviceClient.java index 2ba3be8b..e88dff18 100644 --- a/src/main/java/cn/jpush/api/device/DeviceClient.java +++ b/src/main/java/cn/jpush/api/device/DeviceClient.java @@ -144,8 +144,6 @@ public DefaultResult updateDeviceTagAlias(String registrationId, String alias, public DefaultResult bindMobile(String registrationId, String mobile) throws APIConnectionException, APIRequestException { - Preconditions.checkNotNull(mobile, "The mobile must not be null."); - if ( StringUtils.isEmpty(mobile) ) { // delete bind while mobile is empty. mobile = ""; diff --git a/src/test/java/cn/jpush/api/device/DeviceNormalRemoteTest.java b/src/test/java/cn/jpush/api/device/DeviceNormalRemoteTest.java index b76d97ae..7ec38820 100644 --- a/src/test/java/cn/jpush/api/device/DeviceNormalRemoteTest.java +++ b/src/test/java/cn/jpush/api/device/DeviceNormalRemoteTest.java @@ -181,4 +181,19 @@ public void testBindMobile() throws APIConnectionException, APIRequestException DefaultResult result = jpushClient.bindMobile(REGISTRATION_ID1, "13000000000"); assertTrue(result.isResultOK()); } + + @Test + @TestOrder(order = 361) + public void testBindMobile_null() throws APIConnectionException, APIRequestException { + DefaultResult result = jpushClient.bindMobile(REGISTRATION_ID1, null); + assertTrue(result.isResultOK()); + } + + @Test + @TestOrder(order = 362) + public void testBindMobile_empty() throws APIConnectionException, APIRequestException { + DefaultResult result = jpushClient.bindMobile(REGISTRATION_ID1, ""); + assertTrue(result.isResultOK()); + } + }