Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose all minion resource requirements to config #82

Closed
jpw1991 opened this issue Feb 9, 2023 · 1 comment · Fixed by #211
Closed

Expose all minion resource requirements to config #82

jpw1991 opened this issue Feb 9, 2023 · 1 comment · Fixed by #211
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@jpw1991
Copy link
Owner

jpw1991 commented Feb 9, 2023

Description

Instead of things like Surtling Cores for mages being a hardcoded requirement, make these things something the user can specify via the config using the <Prefab1>:<quantity>[[,<PreFab2>:<quantity>], ...] template.

Is the feature related to a problem?

Supporting the diverse difficulty requirements of all players.

Approach

Refactor the following:

ArmorLeatherScrapsRequiredConfig = plugin.Config.Bind("SkeletonWand (Server Synced)", "ArmoredSkeletonLeatherScrapsRequired",
                5, new ConfigDescription("The amount of LeatherScraps required to craft a skeleton in leather armor.", null,
                new ConfigurationManagerAttributes { IsAdminOnly = true }));

 ...

            SurtlingCoresRequiredConfig = plugin.Config.Bind("SkeletonWand (Server Synced)", "SkeletonMageSurtlingCoresRequired",
                1, new ConfigDescription("The amount of surtling cores required to craft a skeleton mage.", null,
                new ConfigurationManagerAttributes { IsAdminOnly = true }));

to be more like:

ArmorLeatherRequirementsConfig = plugin.Config.Bind("SkeletonWand (Server Synced)", "ArmoredSkeletonLeatherRequirements",
                "LeatherScraps:5", new ConfigDescription("The items needed to craft an armored skeleton.", null,
                new ConfigurationManagerAttributes { IsAdminOnly = true }));

 ...

            MageRequirementsConfig = plugin.Config.Bind("SkeletonWand (Server Synced)", "SkeletonMageRequirements",
                "SurtlingCore:1", new ConfigDescription("The items needed to craft a skeleton mage.", null,
                new ConfigurationManagerAttributes { IsAdminOnly = true }));
@jpw1991 jpw1991 added the enhancement New feature or request label Feb 9, 2023
@jpw1991 jpw1991 added this to the 1.8.X milestone Feb 9, 2023
@jpw1991 jpw1991 self-assigned this Feb 9, 2023
@jpw1991
Copy link
Owner Author

jpw1991 commented Feb 20, 2023

@Dracbjorn when you're done with your config stuff, we should do this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant