Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JArray fails on Classes and strings in 0.6.3 #356

Merged
merged 4 commits into from Oct 25, 2018

Conversation

Projects
None yet
3 participants
@Thrameos
Copy link
Contributor

Thrameos commented Oct 23, 2018

Somehow during some work on the JArray a bug was introduced that removed two required paths for the JArray constructor. issubclass does not work on strings and thus the first path failed. The test for a class instance was also incorrect. It appears that we had some holes in our test coverage that was not checking this pattern.

I corrected the logic and added appropriate tests for each of the patterns.

Thrameos added some commits Oct 23, 2018

@AppVeyorBot

This comment has been minimized.

Copy link

AppVeyorBot commented Oct 24, 2018

@Thrameos

This comment has been minimized.

Copy link
Contributor Author

Thrameos commented Oct 25, 2018

The build fail appears to be a failure in cinst ant. I will try to make the failure more explicit. Not sure how to address the ANT_HOME problem.

@Thrameos Thrameos merged commit 85d9a60 into jpype-project:master Oct 25, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Thrameos Thrameos deleted the Thrameos:arraybug branch Oct 25, 2018

@marscher

This comment has been minimized.

Copy link
Collaborator

marscher commented Oct 25, 2018

@Thrameos

This comment has been minimized.

Copy link
Contributor Author

Thrameos commented Oct 25, 2018

The odd thing is that the ant choco install file sets the ANT_HOME, so the issue appears to be that the variable is set in one place and then does not appear when we go to run. Either that or the original setting of ANT_HOME was not required. I am going to do a few test pulls with different settings. But I am not really sure when appveyor is running or not. The travis build is running every time a push occurs but the appveyor is only appearing occasionally. It may be a configuration problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.