Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for building manylinux1 wheels #559

Merged
merged 1 commit into from Jan 8, 2020
Merged

Conversation

@Thrameos
Copy link
Contributor

Thrameos commented Jan 8, 2020

Fixes #557

This pull request adds scripts to use docker to build manylinux wheels.

@Thrameos Thrameos requested a review from marscher Jan 8, 2020
@Thrameos Thrameos self-assigned this Jan 8, 2020
@Thrameos Thrameos added the enhancement label Jan 8, 2020
@marscher

This comment has been minimized.

Copy link
Collaborator

marscher commented Jan 8, 2020

Hi, this will greatly simplify things. Is there also a Dockerfile to specify the containers details?

@Thrameos

This comment has been minimized.

Copy link
Contributor Author

Thrameos commented Jan 8, 2020

Yes the dockers are from github manylinux repo. We can likely build our own if you would like.

https://github.com/pypa/manylinux

@marscher

This comment has been minimized.

Copy link
Collaborator

marscher commented Jan 8, 2020

@Thrameos

This comment has been minimized.

Copy link
Contributor Author

Thrameos commented Jan 8, 2020

No building the sdist locally removes that dependency. Thus could use manylinux out of box

@Thrameos

This comment has been minimized.

Copy link
Contributor Author

Thrameos commented Jan 8, 2020

We cant actually test them in the docker without java, but we can build them.

@marscher

This comment has been minimized.

Copy link
Collaborator

marscher commented Jan 8, 2020

@marscher

This comment has been minimized.

Copy link
Collaborator

marscher commented Jan 8, 2020

@Thrameos Thrameos merged commit 915374d into jpype-project:master Jan 8, 2020
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Thrameos

This comment has been minimized.

Copy link
Contributor Author

Thrameos commented Jan 8, 2020

Do you know how to push the results to pypi? I pushed them to github release for now.

@marscher

This comment has been minimized.

Copy link
Collaborator

marscher commented Jan 8, 2020

I can upload them.

@marscher

This comment has been minimized.

Copy link
Collaborator

marscher commented Jan 8, 2020

I guess we also want to have builds for Python 3.8

@Thrameos

This comment has been minimized.

Copy link
Contributor Author

Thrameos commented Jan 8, 2020

Okay i can add them to the build but it wont be until evening PST.

@marscher

This comment has been minimized.

Copy link
Collaborator

marscher commented Jan 8, 2020

400 Binary wheel 'JPype1-0.7.1-cp35-cp35m-linux_x86_64.whl' has an unsupported platform tag 'linux_x86_64'

I think it should be manylinux. Somethings wrong. I guess these need to be converted somehow.

@Thrameos

This comment has been minimized.

Copy link
Contributor Author

Thrameos commented Jan 8, 2020

Perhaps we need to add auditwheel repair to the build pattern.

@Thrameos

This comment has been minimized.

Copy link
Contributor Author

Thrameos commented Jan 8, 2020

There is a manylinux demo on github that i was working from. Perhaps i missed a step.

@Thrameos

This comment has been minimized.

Copy link
Contributor Author

Thrameos commented Jan 8, 2020

Also possible the no index flag was a requirement. Will have to investigate further.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.