Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes tags for manylinux #560

Merged
merged 1 commit into from Jan 10, 2020
Merged

Fixes tags for manylinux #560

merged 1 commit into from Jan 10, 2020

Conversation

@Thrameos
Copy link
Contributor

Thrameos commented Jan 8, 2020

@marscher Okay second attempt on this one. Please try to upload the whls and see if it is working now.

@marscher

This comment has been minimized.

Copy link
Collaborator

marscher commented Jan 10, 2020

LGTM. Now PyPI complains about the language tag we use in setup.py:

HTTPError: 400 Client Error: Invalid value for classifiers. Error: 'Programming Language :: Java :: 8' is not a valid choice for this field for url: https://upload.pypi.org/legacy/
@marscher

This comment has been minimized.

Copy link
Collaborator

marscher commented Jan 10, 2020

https://pypi.org/classifiers/ It seems there is only Java allowed, but now specific version. I think it sufficient to have the supported versions only in the long_description of setup.py. That way this information is also bound to a jpype release.

@Thrameos

This comment has been minimized.

Copy link
Contributor Author

Thrameos commented Jan 10, 2020

Okay, so I need to edit it and resubmit?

@Thrameos

This comment has been minimized.

Copy link
Contributor Author

Thrameos commented Jan 10, 2020

Okay I think I am very confused. I looked at the setup and the unpacked the wheels and I don't see "Java :: 8" anywhere.

I thought we deleted the Java classifier a long time ago. (Jun 22, 2019, patch "Changes for pypi push")

    classifiers=[
        'Programming Language :: Python :: 2',
        'Programming Language :: Python :: 2.7',
        'Programming Language :: Python :: 3',
        'Programming Language :: Python :: 3.5',
        'Programming Language :: Python :: 3.6',
        'Programming Language :: Python :: 3.7',
    ],

Has it reappeared somewhere?

@marscher

This comment has been minimized.

Copy link
Collaborator

marscher commented Jan 10, 2020

Today it worked. I guess it was some kind of pypi caching hickup. Could you please also create a Windows build for Python3.8? Then we should be done.

@marscher marscher merged commit afe8a8b into jpype-project:master Jan 10, 2020
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Thrameos

This comment has been minimized.

Copy link
Contributor Author

Thrameos commented Jan 10, 2020

@marscher

This comment has been minimized.

Copy link
Collaborator

marscher commented Jan 10, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.