New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sort input file list #931
Sort input file list #931
Conversation
so that _jpype.cpython-36m-x86_64-linux-gnu.so builds in a reproducible way in spite of indeterministic filesystem readdir order and http://bugs.python.org/issue30461 See https://reproducible-builds.org/ for why this is good.
Codecov Report
@@ Coverage Diff @@
## master #931 +/- ##
==========================================
- Coverage 87.76% 87.75% -0.01%
==========================================
Files 112 112
Lines 10011 10011
Branches 4045 4045
==========================================
- Hits 8786 8785 -1
Misses 622 622
- Partials 603 604 +1
Continue to review full report at Codecov.
|
|
Though I am not aware of any issues with build reproducablity on this project, your request seems reasonable. However in reviewing the supporting documentation I have some questions... why put in pull requests on individual projects rather than one in distutils? I can see why the request to update glob was rejected, but perhaps it would be best to patch in distutils/commands/build_ext.py rather than update individual projects. For example in build_ext where the extension sources is converted to a list it would be easy to add a source which would make for repeatable builds without the effort of addressing individual projects. |
|
It seems, I already did that 2 years ago in python/cpython#12341 - maybe backporting it to the older python branches would be good... |
|
Okay so it is handled up stream. It seems though that the best place in jpype is in line 36 of setup_ext/platform.py or line 34 of setup_ext/utils.py rather than at the top level of the set up. We use a glob command there which handles all the sources and would hit any future directories added to the process. |
Does it also exist in setuptools? It would be possible to set a minimum supported setuptools for building jpype using |
|
@marscher So should we move it to the common point or accept as is? |
|
Lgtm
--
Diese Nachricht wurde von meinem Android-Gerät mit K-9 Mail gesendet.
|
|
I guess it is totally safe to sort, until it will be dealt with upstream. |
Sort input file list
so that
_jpype.cpython-36m-x86_64-linux-gnu.sobuilds in a reproducible wayin spite of indeterministic filesystem readdir order
and http://bugs.python.org/issue30461
See https://reproducible-builds.org/ for why this is good.