Addons v2 #73

Closed
wants to merge 5 commits into
from

Conversation

Projects
None yet
2 participants
@spraints
Contributor

spraints commented Mar 4, 2012

The v2 version of #69

@spraints

This comment has been minimized.

Show comment Hide comment
@spraints

spraints Mar 4, 2012

Contributor

I put this together pretty quickly, so please do a sanity check before pulling it in.

Sorry about the extra commits... if you want me to start from a different branch (I started from v2.0.0), let me know and I can redo the pull request.

Also, I noticed that heroku_san now has a tasks.rb and railtie.rb in the top-level lib directory. It seems like these should be in lib/heroku_san?

Contributor

spraints commented Mar 4, 2012

I put this together pretty quickly, so please do a sanity check before pulling it in.

Sorry about the extra commits... if you want me to start from a different branch (I started from v2.0.0), let me know and I can redo the pull request.

Also, I noticed that heroku_san now has a tasks.rb and railtie.rb in the top-level lib directory. It seems like these should be in lib/heroku_san?

@kmayer

This comment has been minimized.

Show comment Hide comment
@kmayer

kmayer Mar 4, 2012

Contributor

Need to write some tests around this. We might also benefit from completing #74 first.

Contributor

kmayer commented Mar 4, 2012

Need to write some tests around this. We might also benefit from completing #74 first.

@spraints

This comment has been minimized.

Show comment Hide comment
@spraints

spraints Mar 5, 2012

Contributor

The updated cukes need the pull request I sent for the demo repo. Let me know what you think.

I agree that #74 would be good to do.

Contributor

spraints commented Mar 5, 2012

The updated cukes need the pull request I sent for the demo repo. Let me know what you think.

I agree that #74 would be good to do.

@spraints

This comment has been minimized.

Show comment Hide comment
@spraints

spraints Mar 29, 2012

Contributor

FYI - I'm rebasing/rewriting to get this to apply cleanly on master. I'll send a new pull request when I get that done.

Contributor

spraints commented Mar 29, 2012

FYI - I'm rebasing/rewriting to get this to apply cleanly on master. I'll send a new pull request when I get that done.

@spraints spraints closed this Mar 29, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment