Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syncterm fix for display_banner and a cp437 switch for the tetris script #143

Merged
merged 3 commits into from Dec 10, 2014

Conversation

@ericolito
Copy link
Contributor

ericolito commented Dec 10, 2014

No description provided.

@ericolito ericolito changed the title Syncterm fix for display_banner Syncterm fix for display_banner and a cp437 switch for the tetris script Dec 10, 2014
@haliphax

This comment has been minimized.

Copy link
Collaborator

haliphax commented Dec 10, 2014

Any reason you use '\r' and not '\r\n'?

	modified:   x84/default/tetris.py
@ericolito

This comment has been minimized.

Copy link
Contributor Author

ericolito commented Dec 10, 2014

Yeah. I wanted it to move the cursor to the first column in order to do clear_eol and remove the leftovers of the syncterm font changing code.

@jquast

This comment has been minimized.

jquast added a commit that referenced this pull request Dec 10, 2014
Syncterm fix for display_banner and a cp437 switch for the tetris script
@jquast jquast merged commit 8a57628 into jquast:master Dec 10, 2014
@haliphax

This comment has been minimized.

Copy link
Collaborator

haliphax commented Dec 10, 2014

Agreed. Syncterm can get weird with \r sometimes, using it as \n instead.

@ericolito

This comment has been minimized.

Copy link
Contributor Author

ericolito commented Dec 10, 2014

alrighty, ill send another pull request

@ericolito

This comment has been minimized.

Copy link
Contributor Author

ericolito commented Dec 10, 2014

Though the whole system is flooded with \r\n already so it shouldnt be a problem? ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.