Skip to content
This repository has been archived by the owner. It is now read-only.

Syncterm fix for display_banner and a cp437 switch for the tetris script #143

Merged
merged 3 commits into from Dec 10, 2014
Merged

Syncterm fix for display_banner and a cp437 switch for the tetris script #143

merged 3 commits into from Dec 10, 2014

Conversation

ericolito
Copy link
Contributor

@ericolito ericolito commented Dec 10, 2014

No description provided.

@ericolito ericolito changed the title Syncterm fix for display_banner Syncterm fix for display_banner and a cp437 switch for the tetris script Dec 10, 2014
@haliphax
Copy link
Collaborator

@haliphax haliphax commented Dec 10, 2014

Any reason you use '\r' and not '\r\n'?

	modified:   x84/default/tetris.py
@ericolito
Copy link
Contributor Author

@ericolito ericolito commented Dec 10, 2014

Yeah. I wanted it to move the cursor to the first column in order to do clear_eol and remove the leftovers of the syncterm font changing code.

@jquast
Copy link
Owner

@jquast jquast commented Dec 10, 2014

jquast added a commit that referenced this issue Dec 10, 2014
Syncterm fix for display_banner and a cp437 switch for the tetris script
@jquast jquast merged commit 8a57628 into jquast:master Dec 10, 2014
@haliphax
Copy link
Collaborator

@haliphax haliphax commented Dec 10, 2014

Agreed. Syncterm can get weird with \r sometimes, using it as \n instead.

@ericolito
Copy link
Contributor Author

@ericolito ericolito commented Dec 10, 2014

alrighty, ill send another pull request

@ericolito
Copy link
Contributor Author

@ericolito ericolito commented Dec 10, 2014

Though the whole system is flooded with \r\n already so it shouldnt be a problem? ;)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants