Skip to content
This repository has been archived by the owner. It is now read-only.

sftp server, file browser #145

Merged
merged 1 commit into from Dec 26, 2014
Merged

sftp server, file browser #145

merged 1 commit into from Dec 26, 2014

Conversation

haliphax
Copy link
Collaborator

@haliphax haliphax commented Dec 14, 2014

configuration

to configure sftp server:

  • add [sftp] section to default.ini
  • add root option to [sftp] section, pointing at root folder for files
  • (optionally) add umask option to [sftp] section for default umask on uploaded files

to enable uploads:

  • create __uploads__ directory in sftp root

to enable file browser:

  • add menu option for gosub('fbrowse')

things to add

  • FILE_ID.DIZ caching, but that seems like premature optimization at this point
  • ability to enter manual descriptions for files (will depend on same storage mechanism that holds FILE_ID.DIZ cache)
  • virtual FILES.BBS generation so that sftp clients can view descriptions of a folder's files without being logged in via terminal server
  • integration with x/84's IPC logging mechanism
  • better detection of file download completion (currently, file is removed from user's tagged list as soon as it is opened via sftp, rather than when it is finished)
  • tracking uploads/downloads (i.e., who uploaded what, how many times has something been downloaded, who downloaded what, etc.)

notes

  • this adds filesize to common.py for a human-readable file size function as per #146

# @TODO add support for DMS archives


""" archive extraction functions """
Copy link
Owner

@jquast jquast Dec 15, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this would become a docstring for the module, following "File browsing/tagging for..."

Copy link
Owner

@jquast jquast Dec 15, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that is, nix it, or change it to ## comments

Copy link
Collaborator Author

@haliphax haliphax Dec 16, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand that it's the docstring. Is it wrong? Or are you referring to the "archive extraction functions" portion? Hard to tell based on what you've highlighted.

Copy link
Owner

@jquast jquast Dec 16, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the doc builds aren't very easy right now, I'll work on them again in the coming weeks -- But the API documents would have an "overview" or top-level description, and currently it would read:

File browsing/tagging for x/84 bbs https://github.com/jquast/x84

archive extraction functions

config

script logic

followed by all of the methods/functions here. As these are on the top-level (no indent), they are not attatched to anything in particular, just the top-level module

Copy link
Collaborator Author

@haliphax haliphax Dec 18, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gotcha. That was the clarification I needed. I'll move them into # comments, instead.

jquast added a commit that referenced this issue Dec 26, 2014
@jquast jquast merged commit 82d1e96 into jquast:master Dec 26, 2014
@jquast
Copy link
Owner

@jquast jquast commented Dec 26, 2014

big brother thanks you, comrade

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants