Skip to content
This repository

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Module-Build-Tiny compatibility. #3

Open
wants to merge 2 commits into from

1 participant

Shlomi Fish
Shlomi Fish

Hi Jerome!

I added Module-Build-Tiny compatibility. See: https://rt.cpan.org/Ticket/Display.html?id=86240 . Please merge.

Regards,

-- Shlomi Fish

added some commits May 31, 2012
Shlomi Fish License should be more standard.
See:

http://fedoraproject.org/wiki/Packaging/LicensingGuidelines .

License should read "GPLv1+ or Artistic" instead of "GPL+ or Artistic".
rpmlint complained about that.
7927831
Shlomi Fish Add double dashes for M-B-Tiny compat.
The double dashes ("--") are for Module::Build::Tiny compatibility:
     * https://rt.cpan.org/Ticket/Display.html?id=86240
     * https://wiki.mageia.org/en/Perl_policy

BTW, shouldn't we use Module::Build whenver there's a Build.PL even if
a Makefile.PL does not exist?
fd2e79d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Showing 2 unique commits by 1 author.

Jun 21, 2013
Shlomi Fish License should be more standard.
See:

http://fedoraproject.org/wiki/Packaging/LicensingGuidelines .

License should read "GPLv1+ or Artistic" instead of "GPL+ or Artistic".
rpmlint complained about that.
7927831
Shlomi Fish Add double dashes for M-B-Tiny compat.
The double dashes ("--") are for Module::Build::Tiny compatibility:
     * https://rt.cpan.org/Ticket/Display.html?id=86240
     * https://wiki.mageia.org/en/Perl_policy

BTW, shouldn't we use Module::Build whenver there's a Build.PL even if
a Makefile.PL does not exist?
fd2e79d
This page is out of date. Refresh to see the latest.
7  lib/CPANPLUS/Dist/Mageia.pm
@@ -153,10 +153,13 @@ sub prepare {
153 153
         $distinstall = "%makeinstall_std";
154 154
     } else {
155 155
         # module::build only distribution
  156
+        # The double dashes ("--") are for Module::Build::Tiny compatibility:
  157
+        #   * https://rt.cpan.org/Ticket/Display.html?id=86240
  158
+        #   * https://wiki.mageia.org/en/Perl_policy
156 159
         push @reqs, 'Module::Build';
157  
-        $distbuild = "%{__perl} Build.PL installdirs=vendor\n";
  160
+        $distbuild = "%{__perl} Build.PL --installdirs=vendor\n";
158 161
         $distmaker = "./Build";
159  
-        $distinstall = "./Build install destdir=%{buildroot}";
  162
+        $distinstall = "./Build install --destdir=%{buildroot}";
160 163
     }
161 164
     my $distbreqs      = join "\n", map { "BuildRequires: perl($_)" } 
162 165
                          grep { $_ ne "perl" } @reqs;
2  share/template.spec
@@ -6,7 +6,7 @@ Version:    %perl_convert_version %{upstream_version}
6 6
 Release:    %mkrel 1
7 7
 
8 8
 Summary:    DISTSUMMARY
9  
-License:    GPL+ or Artistic
  9
+License:    GPLv1+ or Artistic
10 10
 Group:      Development/Perl
11 11
 Url:        http://search.cpan.org/dist/%{upstream_name}
12 12
 Source0:    http://www.cpan.org/modules/by-module/DISTTOPLEVEL/%{upstream_name}-%{upstream_version}.DISTEXTENSION
Commit_comment_tip

Tip: You can add notes to lines in a file. Hover to the left of a line to make a note

Something went wrong with that request. Please try again.