New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CPAN PR Challenge: January #5

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@gryphonshafer
Contributor

gryphonshafer commented Jan 16, 2015

As part of the CPAN PR Challenge for the month of January, I've been assigned Dist::Zilla::Plugin::Test::Perl::Critic. It looks like a pretty good and straight-forward module. I wasn't sure there was anything I could do to improve on it. In my own testing, I discovered a missing dependency of Test::Perl::Critic, so I included that explicitly in the dist.ini file. To try to address the comment from https://rt.cpan.org/Public/Bug/Display.html?id=70846, I tried adding and rewriting a little bit of the description content in the POD.

@jquelin

This comment has been minimized.

Show comment
Hide comment
@jquelin

jquelin Jan 21, 2015

Owner

thanks, merged & released as 3.000

Owner

jquelin commented Jan 21, 2015

thanks, merged & released as 3.000

@jquelin jquelin closed this Jan 21, 2015

@gryphonshafer

This comment has been minimized.

Show comment
Hide comment
@gryphonshafer

gryphonshafer Jan 21, 2015

Contributor

You're welcome, and thanks for the quick merge.

Contributor

gryphonshafer commented Jan 21, 2015

You're welcome, and thanks for the quick merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment