Skip to content
This repository has been archived by the owner. It is now read-only.

Beta 2: ui-body-swatch class reapplied to content #2221

Closed
abdulqadir opened this issue Aug 5, 2011 · 1 comment
Closed

Beta 2: ui-body-swatch class reapplied to content #2221

abdulqadir opened this issue Aug 5, 2011 · 1 comment

Comments

@abdulqadir
Copy link

abdulqadir commented Aug 5, 2011

The class for the page theme is added to the content div if no separate theme swatch for data-role="content" is specified.

This makes the background gradient look jarred if the page is short on content.
Please see http://jsfiddle.net/abdulqadir/cvzZD/

If we go back to the previous method of applying a theme to the content area only if one is explicitly specified, the effect is a lot smoother.

Modifying line 82 in jquery.mobile.page.sections.js from

$this.addClass( "ui-body-" + ( theme || pageTheme || o.contentTheme ) );

to

if (theme || o.contentTheme) {
    $this.addClass( "ui-body-" + ( theme || o.contentTheme ) );
}

would bring back the old functionality

@scottjehl
Copy link

scottjehl commented Aug 5, 2011

Great point. This is one regression that occurred during decoupling that I'd been trying to track down. We'll get this in asap!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants