Discussion: Bootstrap 1.0 or shift to 2.0 (once final) #52

Closed
addyosmani opened this Issue Jan 25, 2012 · 102 comments

Projects

None yet
@addyosmani
jquery-ui-bootstrap member

I've just been reviewing Twitter Bootstrap 2.0 WIP and it introduces both a large number of new visual components and quite a shift in the visual appearance of the project since 1.0. At the request of the Bootstrap team, the WIP isn't being put up anywhere live pre-release but if you'd like to review it, you can grab 2.0 WIP here: https://github.com/twitter/bootstrap/tree/2.0-wip

This raises some interesting questions about how jQuery UI Bootstrap should proceed:

  • Should we stick with version 1.0 of Bootstrap and continue improving support for it as well as theming more plugins? (this would effectively mean we're providing a 'Bootstrap' jQuery UI theme, but not supporting Twitter Bootstrap (latest). Arguments for: the current theme is visually pleasing and our time could be spent improving support for more third party plugins if we stayed this course. There is a need for a stable, modern theme in the community.

  • Should we move to Bootstrap 2.0 (once final)? This will involve a very large amount of work. a) We'll have to retheme the existing components, b) extend our support to cover more 'modes' that can be customized using jQuery UI which are being included by default in Bootstrap 2.0 and c) cover support for plugins/otherwise that can match as much as possible 2.0. Arguments for: this will improve the overall visuals the theme offers, developers will be able to continue to use Bootstrap.latest and jQuery UI.latest together.

Could I have a show of votes? +1 to upgrade to 2.0, -1 to stick with 1.0 and do our own thing.

Happy to also hear further input from others about their thoughts on the above.

@JamesMGreene

+1

Though you should probably leave a cut of 1.0 available for download.

@jlnslv

+1

@tud

+1

@patik

+1

@nexeck

+1

@ddprrt

+1

@iknite

+1

@davej

+1

@daFish

+1

@huzzi

+1

@mntbkr

+1

@paglias

+1

@studioromeo

@sindresorhus how on earth did you do that?!

+1 although if you like 1.0 then theres no harm in sticking with that I guess

@paglias

using this code ````
👍

@jerriep

+1

@svnlto

🐳

@jlsync

+1

@Hquant

+1

@euge

+1

@clannadsystems

+1 coz i need to play with new features now and i couldnt wait.

@nfaiz

+1

@ajrkerr

+1

@zowber

+1

@yorktsai

+1

@beata

+1

@diimpp

+1

@jahvi

👍

@alien3d

+1

@gpetrov

+1 and Bootstrap 2.0 is final now

@havvg

+2.0

@antage

+1

@rdandy

+1

@mdeltito

+1

@p3drosola

+1

I love the responsive design support.

@bdufresne

-1 (just kidding)

@ghost

+1

@volksman

+1

@nukr

+1

@panos-kosmidis

@addyosmani I did some briefly integration of jquery ui bootstrap with bootstrap 2 but I didn't changed the custom jquery ui theme I just added bootstrap 2 css and js...

The big work is to convert old jquery ui theme to look more like bootstrap 2.0 theme.

Maybe I'll work a bit more on that and dedicate some time on it.

The good part also is that now you don't need to hack bootstrap css files because it seems it don't break anything in jquery ui, it was plug-and-play so far with my tests.

You can check a preview here nothing impressive so far, just playing around...

EDIT:
@addyosmani maybe jquery ui bootstrap theme should be made with less in order to get bootstrap's variables and use them instead of hard-coding them, this will make the upgrade easier for future changes of bootstrap.

@havvg havvg referenced this issue Feb 2, 2012
Closed

Using Bootstrap 2.0 #55

@Azzurrio

+1

@addyosmani
jquery-ui-bootstrap member

@panosru You raise a very valid point. One of the issues with building the first version was a heavy reliance on custom matching color schemes and where possible, I'd like to avoid this for the next version. I'm not the biggest fan in the world of LESS, but I'll try to experiment with it as an option :) It would definitely make maintaining sync with future versions of Bootstrap a lot easier than it is now.

You may remember seeing a previous PR with a LESS version of the theme. Given that there are still some components in Bootstrap 2 that haven't hugely changed, do you think it's worth cleaning that up and using it as a base or starting from scratch?

@panos-kosmidis

@addyosmani Not only it would make maintaining new versions of bootstrap easier but as you noticed bootstrap 2 provides the ability of customization as a result if I customize my version of bootstrap then jquery ui bootstrap theme will adopt on my settings. I'm not really sure about that though because so far from what I noticed is that the customization tool generate's css and not less files, but either-way at least maintaining would be much easier to do.

Yes I remember you talking about Pull #41 by @t1gr0u I did a check again on that and it seems already good to me, I would prefer to start from that instead of from scratch (even if generally I always prefer to do things from scratch) I guess it worth of working on it for bootstrap 2 integration.

Another point I want to mention is that we shouldn't touch bootstrap's code, what I mean is that for instance in jquery ui bootstrap 1 some bootstrap css break some our jquery interface etc so we had to touch bootstrap's [le|c]ss files, I would suggest instead to have a style.less which would @import bootstrap.less and after that @import jquery-ui-bootstrap.less so we could override anything we need from bootstrap without interacting with core files of bootstrap, this will also help us for better maintenance, and better overlook of changes we did. So far that I test bootstrap2 with jquery ui bootstrap seems that bootstrap 2 works fine with jquery ui theme and does not break anything, so no overriding is needed.

@t1gr0u

hi @panosru, @addyosmani,

let me if I can be any help on the LESS files

@svnlto

This might be a good starting point, only if I'm not missing the point completely :)

https://github.com/svnlto/jQueryUILess

@panos-kosmidis

@svnlto I prefer to break apart @t1gr0u 's less file since he already added the variables in his less file so it would be much easier :) but this could be a good example on how we should abstract our theme in order to have a better scope of the code :)

@panos-kosmidis

Also something about +1, I believe no more +1 are needed, we got the point now what is needed is contribution to make it happen :)

@t1gr0u

breaking the files would be good

@xcambar

simply: +1

@t1gr0u

i've broke down the LESS file: https://github.com/t1gr0u/jquery-ui-bootstrap

@panos-kosmidis

@t1gr0u good work! I like it like that :)

@t1gr0u

it make easier to work on and to update :)

@svnlto

@t1gr0u good work!

@t1gr0u

@panosru , @svnlto thank you :)

@henvic

+1

@addyosmani
jquery-ui-bootstrap member

@panosru Due to the number of votes we're continuing to receive on this and the fact the decision is now unanimous I think I'm going to close this thread and open a new one for 2.0 discussions solely.

@addyosmani addyosmani closed this Feb 3, 2012
@adityamenon

@tjgillies

the only octo anything "actual" emoji is 🐙

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment