Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't require jQuery in jquery.ui.core #21

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
6 participants
@kossnocorp
Copy link

commented Nov 1, 2012

It's important to keep ability to require jquery manually.

For example if you are using CDN (https://github.com/kenn/jquery-rails-cdn) jQuery will be required twice.

@glebm

This comment has been minimized.

Copy link

commented Nov 3, 2012

If you put yours in vendor/assets/jquery.js it should only require it once (does work for me)

@glebm

This comment has been minimized.

Copy link

commented Nov 3, 2012

Oh but you can't split jquery away from application code otherwise (apart from having an empty vendor/assets/jquery.js).
+1 to this pull request

@HurricaneJames

This comment has been minimized.

Copy link

commented Nov 6, 2012

+1

I'm working on a complex application and this caused me a full day of debug trying to figure out why previously working code now failed to work after switching from jammit to the asset pipeline.

For example, look at the jquery/jquery_ujs model. jquery_ujs does not require jquery, it requires that I require jquery.

@chitsaou

This comment has been minimized.

Copy link

commented Nov 9, 2012

Our fork techbang/jquery-ui-rails does handle this situation. We load jQuery from CDN, with a local-fallback from our server. Also we've removed //= require jquery from jquery.ui.core.js, so there will be no duplicated jQuery evaluation or script download.

@styx

This comment has been minimized.

Copy link

commented Nov 13, 2012

👍

@joliss

This comment has been minimized.

Copy link
Member

commented Nov 17, 2012

(This would fix #17.)

I like the intent of this pull request, but the vendor files are generated. Could you please resubmit a pull request that modifies Rakefile instead? Then rerun rake and check in the regenerated files as well.

This way, this change doesn't get overwritten next time we upgrade jQuery UI.

@joliss joliss closed this Nov 17, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.