Make cancel buttons a setting #473

Closed
Jelle-S opened this Issue Aug 8, 2012 · 6 comments

Comments

Projects
None yet
2 participants
@Jelle-S

Jelle-S commented Aug 8, 2012

At the moment, buttons with the 'cancel' class don't trigger validation. It would be nice if this was a setting we could pass through. We especially need this at our Drupal module Clientside Validation where we do not control the classes buttons may or may not have. See related issue in our issue queue.

@jzaefferer

This comment has been minimized.

Show comment Hide comment
@jzaefferer

jzaefferer Aug 8, 2012

Collaborator

A cancelClass: "cancel" option would help?

Collaborator

jzaefferer commented Aug 8, 2012

A cancelClass: "cancel" option would help?

@Jelle-S

This comment has been minimized.

Show comment Hide comment
@Jelle-S

Jelle-S Aug 8, 2012

More like the ignore option is now, so we can enter a jquery selector:
cancel: ".cancel" as default, but if we want we could enter cancel: ".cancel, .my-custom-cancel-class"
That would be awesome! ;-)

Jelle-S commented Aug 8, 2012

More like the ignore option is now, so we can enter a jquery selector:
cancel: ".cancel" as default, but if we want we could enter cancel: ".cancel, .my-custom-cancel-class"
That would be awesome! ;-)

@jzaefferer

This comment has been minimized.

Show comment Hide comment
@jzaefferer

jzaefferer Aug 8, 2012

Collaborator

That makes sense, thanks for the input. A PR is welcome, too, and would make it a little faster to land this.

Collaborator

jzaefferer commented Aug 8, 2012

That makes sense, thanks for the input. A PR is welcome, too, and would make it a little faster to land this.

@Jelle-S

This comment has been minimized.

Show comment Hide comment
@Jelle-S

Jelle-S Aug 8, 2012

I'm quite busy at the moment (undoubtedly you are too :-) ). I'll try to find some time though

Jelle-S commented Aug 8, 2012

I'm quite busy at the moment (undoubtedly you are too :-) ). I'll try to find some time though

@Jelle-S

This comment has been minimized.

Show comment Hide comment
@jzaefferer

This comment has been minimized.

Show comment Hide comment
@jzaefferer

jzaefferer Jun 26, 2015

Collaborator

I'm sorry for the lack of activity on this issue. Instead of leaving it open any longer, I decided to close old issues without trying to address them, to longer give the false impression that it will get addressed eventually.

To the reporter (or anyone else interested in this issue): If you're affected by the same issue, consider opening a new issue, with a testpage that shows the issue. Even better, try to fix the issue yourself, and improve the project by sending a pull request. This may seem daunting at first, but you'll likely learn some useful skills that you can apply elsewhere as well. And you can help keep this project alive. We've documented how to do these things, too. A patch is worth a thousand issues!

Collaborator

jzaefferer commented Jun 26, 2015

I'm sorry for the lack of activity on this issue. Instead of leaving it open any longer, I decided to close old issues without trying to address them, to longer give the false impression that it will get addressed eventually.

To the reporter (or anyone else interested in this issue): If you're affected by the same issue, consider opening a new issue, with a testpage that shows the issue. Even better, try to fix the issue yourself, and improve the project by sending a pull request. This may seem daunting at first, but you'll likely learn some useful skills that you can apply elsewhere as well. And you can help keep this project alive. We've documented how to do these things, too. A patch is worth a thousand issues!

@jzaefferer jzaefferer closed this Jun 26, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment