Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Don't prevent form submit when using a submitHander #650
If I add a
Line 68 in the current code would become
var result = validator.settings.submitHandler.call( validator, validator.currentForm, event );
and line 73
(instead of return false)
This update is great, but it does break existing code that assumes that the native submit is prevented. That being the case, it probably should have been part of a minor release instead of a bug fix release (ie. 1.14.x instead of 1.13.1). Many of my form submissions broke after bower updated this plugin from 1.13.0 to 1.13.1.
You're right, that shouldn't have gone into a patch release, sorry about that. I could revert to the previous behaviour in a 1.13.2 release, but with 1.13.1 out the door for two months, I suspect that the revert would be just as problematic, since it would break code that relies on the new behaviour.
What do you think?