Strange unused setting #676

Closed
glat opened this Issue Mar 7, 2013 · 1 comment

Comments

Projects
None yet
2 participants
@glat

glat commented Mar 7, 2013

This line:

if (this.settings.focusCleanup && !this.blockFocusCleanup) {

is very strange because focusCleanup is not defined in settings and blockFocusCleanup was never created.

Please check it.

@stijnherreman

This comment has been minimized.

Show comment
Hide comment
@stijnherreman

stijnherreman Sep 27, 2013

focusCleanup defaults to false according to the documentation. In reality, it's not defined, but the if() will evaluate it as false.
blockFocusCleanup is also undefined, so it won't influence the outcome, but it seems rather unnecessary. It's just the opposite of the first property.
It's not possible to tell why this was added, because it's been there since the first (public) commit.

focusCleanup defaults to false according to the documentation. In reality, it's not defined, but the if() will evaluate it as false.
blockFocusCleanup is also undefined, so it won't influence the outcome, but it seems rather unnecessary. It's just the opposite of the first property.
It's not possible to tell why this was added, because it's been there since the first (public) commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment