Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced deprecated jQuery functions #2335

Merged
merged 1 commit into from Jun 24, 2020

Conversation

@bytestream
Copy link
Contributor

@bytestream bytestream commented Jun 23, 2020

Description

Replaces functions deprecated in jQuery 3 as per https://api.jquery.com/category/deprecated/

@bytestream bytestream force-pushed the jquery-deprecations branch from ba82525 to 38882c7 Jun 23, 2020
@bytestream bytestream changed the title jQuery deprecations Replaced deprecated jQuery functions Jun 23, 2020
@bytestream bytestream force-pushed the jquery-deprecations branch from 38882c7 to 272bb4f Jun 23, 2020
staabm
staabm approved these changes Jun 23, 2020
Copy link
Member

@staabm staabm left a comment

Lgtm - thank you

@staabm staabm requested a review from Arkni Jun 23, 2020
Copy link
Member

@Arkni Arkni left a comment

Overall, it looks good to me. I left a comment about the isArray method that I would like to discuss

src/core.js Outdated Show resolved Hide resolved
Replaced $.isArray and $.isFunction
@bytestream bytestream force-pushed the jquery-deprecations branch from 272bb4f to 360de29 Jun 24, 2020
Arkni
Arkni approved these changes Jun 24, 2020
Copy link
Member

@Arkni Arkni left a comment

LGTM

Thanks a lot for your contribution :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants